mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
	luc.vanoostenryck@gmail.com
Subject: [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot
Date: Sun,  7 Jun 2015 11:01:24 +0200	[thread overview]
Message-ID: <1433667684-10057-1-git-send-email-mcoquelin.stm32@gmail.com> (raw)

This patch fixes below error spotted by kbuild test robot when building
with ARCH=ia64:

All error/warnings (new ones prefixed by >>):

        drivers/clocksource/timer-stm32.c:38:28: error: field 'evtdev' has incomplete type

     struct clock_event_device evtdev;
                               ^

        drivers/clocksource/timer-stm32.c:44:19: warning: 'enum clock_event_mode' declared inside parameter list

               struct clock_event_device *evtdev)

The fix consists in making the STM32 timer depend on GENERIC_CLOCKEVENTS.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index bec25b3..1778c90 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -113,7 +113,7 @@ config CLKSRC_LPC32XX
 
 config CLKSRC_STM32
 	bool "Clocksource for STM32 SoCs" if COMPILE_TEST
-	depends on OF
+	depends on OF && GENERIC_CLOCKEVENTS
 	select CLKSRC_MMIO
 
 config ARM_ARCH_TIMER
-- 
1.9.1


             reply	other threads:[~2015-06-07  9:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-07  9:01 Maxime Coquelin [this message]
2015-06-08 17:39 ` Daniel Lezcano
2015-06-08 20:08   ` Thomas Gleixner
2015-06-08 20:47     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433667684-10057-1-git-send-email-mcoquelin.stm32@gmail.com \
    --to=mcoquelin.stm32@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®