From: Caesar Wang <wxt@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: dianders@chromium.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-rockchip@lists.infradead.org,
Caesar Wang <wxt@rock-chips.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state
Date: Mon, 8 Jun 2015 15:11:35 +0800 [thread overview]
Message-ID: <1433747496-7642-3-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1433747496-7642-1-git-send-email-wxt@rock-chips.com>
The patch can ensure that v7_exit_coherency_flush() in rockchip_cpu_die()
executed in time.
The mdelay(1) has enough time to fix the problem of CPU offlining.
That's a workaround way in rockchip hotplug code,
At least, we haven't a better way to solve it. Who know,
that maybe fixed by chip (hardware) in the future.
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Changes in v5:
- Fix the patch decription.
- Add the changelog.
Changes in v4: None
Changes in v3: None
Changes in v2: None
Changes in v2:
- As Kever points out, Fix the subject typo WFI/WFE.
---
arch/arm/mach-rockchip/platsmp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index bd40852..5bc2a89 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -321,6 +321,9 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus)
#ifdef CONFIG_HOTPLUG_CPU
static int rockchip_cpu_kill(unsigned int cpu)
{
+ /* ensure CPU can enter the WFI/WFE state */
+ mdelay(1);
+
pmu_set_power_domain(0 + cpu, false);
return 1;
}
--
1.9.1
next prev parent reply other threads:[~2015-06-08 7:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 7:11 [PATCH v5 0/3] ARM: rockchip: fix the SMP Caesar Wang
2015-06-08 7:11 ` [PATCH v5 1/3] ARM: rockchip: fix the CPU soft reset Caesar Wang
2015-06-08 7:51 ` Caesar Wang
2015-06-08 9:24 ` Russell King - ARM Linux
2015-06-08 21:54 ` Caesar Wang
2015-06-09 9:55 ` Caesar Wang
2015-06-08 9:43 ` Russell King - ARM Linux
2015-06-09 0:43 ` Caesar Wang
2015-06-09 7:46 ` Heiko Stübner
2015-06-08 7:11 ` Caesar Wang [this message]
2015-06-08 9:28 ` [PATCH v5 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state Russell King - ARM Linux
2015-06-09 0:40 ` Caesar Wang
2015-06-08 7:11 ` [PATCH v5 3/3] ARM: rockchip: fix the SMP code style Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433747496-7642-3-git-send-email-wxt@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®