From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbbFHHqV (ORCPT ); Mon, 8 Jun 2015 03:46:21 -0400 Received: from mga11.intel.com ([192.55.52.93]:14811 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbbFHHqN (ORCPT ); Mon, 8 Jun 2015 03:46:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,572,1427785200"; d="scan'208";a="583908553" From: Chen Lin Z To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, bo.he@intel.com, yanmin_zhang@linux.intel.com, Chen Lin Z Subject: [PATCH] class: Free the kobject.name if kset_register fails Date: Mon, 8 Jun 2015 15:49:37 +0800 Message-Id: <1433749777-9647-1-git-send-email-lin.z.chen@intel.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a memory leak by freeing the memory allocated in kobject_set_name for the kobjet name. unreferenced object 0xe2167700 (size 64): comm "swapper/0", pid 1, jiffies 4294938161 (age 90.540s) hex dump (first 32 bytes): 6d 61 67 6e 65 74 69 63 00 11 c2 c0 1f e9 23 c1 magnetic......#. 18 00 00 00 04 66 9b e4 e0 66 9b e4 94 76 16 e2 .....f...f...v.. backtrace: [] kmemleak_alloc+0x3c/0xa0 [] __kmalloc_track_caller+0x115/0x1d0 [] kvasprintf+0x33/0x60 [] kobject_set_name_vargs+0x22/0x60 [] kobject_set_name+0x11/0x20 [] __class_register+0x8e/0x1e0 [] __class_create+0x4b/0x70 [] mmc3524x_init+0x18/0x97 [] do_one_initcall+0xbc/0x190 [] kernel_init_freeable+0xea/0x18c [] kernel_init+0x10/0xe0 [] ret_from_kernel_thread+0x1b/0x28 [] 0xffffffff Signed-off-by: Chen Lin Z --- drivers/base/class.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/class.c b/drivers/base/class.c index 6e81088..f6e7f53 100644 --- a/drivers/base/class.c +++ b/drivers/base/class.c @@ -200,6 +200,7 @@ int __class_register(struct class *cls, struct lock_class_key *key) error = kset_register(&cp->subsys); if (error) { + kfree(cp->subsys.kobj.name); kfree(cp); return error; } -- 1.9.1