mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ander Conselvan de Oliveira  <ander.conselvan.de.oliveira@intel.com>
To: ville.syrjala@linux.intel.com
Cc: nkalkhof@web.de, jani.nikula@intel.com, daniel.vetter@ffwll.ch,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	torvalds@linux-foundation.org,
	Ander Conselvan de Oliveira 
	<ander.conselvan.de.oliveira@intel.com>
Subject: [PATCH] drm/i915: Properly initialize SDVO analog connectors
Date: Mon,  8 Jun 2015 11:26:30 +0300	[thread overview]
Message-ID: <1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com> (raw)
In-Reply-To: <20150607043253.12f4058e@mir>

In the commit below, I missed the connector allocation in the function
intel_sdvo_analog_init(), leading to those connectors to have a NULL
state pointer.

commit 08d9bc920d465bbbbd762cac9383249c19bf69a2
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Fri Apr 10 10:59:10 2015 +0300

    drm/i915: Allocate connector state together with the connectors

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
 drivers/gpu/drm/i915/intel_sdvo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index d24ef75..aa2fd75 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -2554,7 +2554,7 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device)
 
 	DRM_DEBUG_KMS("initialising analog device %d\n", device);
 
-	intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL);
+	intel_sdvo_connector = intel_sdvo_connector_alloc();
 	if (!intel_sdvo_connector)
 		return false;
 
-- 
2.1.0


  parent reply	other threads:[~2015-06-08  8:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  3:32 git pull] drm for v4.1-rc1 Dave Airlie
2015-04-21 16:07 ` Linus Torvalds
2015-04-21 21:12   ` Bjorn Helgaas
2015-04-23 21:30   ` Bjorn Helgaas
2015-04-23 21:56     ` Matthew Garrett
2015-04-23 22:47       ` Linus Torvalds
2015-04-23 22:59         ` Matthew Garrett
2015-04-24  0:55     ` Alex Deucher
2015-06-05 21:18 ` Stefan Lippers-Hollmann
2015-06-06 23:52   ` Ville Syrjälä
2015-06-07  2:32     ` Stefan Lippers-Hollmann
2015-06-08  8:06       ` Ander Conselvan De Oliveira
2015-06-08  8:29         ` Ander Conselvan De Oliveira
2015-06-08 10:28           ` Stefan Lippers-Hollmann
2015-06-08  8:26       ` Ander Conselvan de Oliveira [this message]
2015-06-08 10:36         ` [Fwd: Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors] Ander Conselvan De Oliveira
2015-06-08 10:50         ` [PATCH] drm/i915: Properly initialize SDVO analog connectors Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com \
    --to=ander.conselvan.de.oliveira@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nkalkhof@web.de \
    --cc=torvalds@linux-foundation.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome