mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Morton <akpm@linux-foundation.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>
Cc: Joe Perches <joe@perches.com>, Al Viro <viro@ZenIV.linux.org.uk>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/8] kernel/trace/trace_events_filter.c: Use strreplace
Date: Tue,  9 Jun 2015 01:26:50 +0200	[thread overview]
Message-ID: <1433806017-10823-3-git-send-email-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <1433806017-10823-1-git-send-email-linux@rasmusvillemoes.dk>

There's no point in starting over every time we see a ','...

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
---
v2: same patch, added Ack.

 kernel/trace/trace_events_filter.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index ced69da0ff55..a987601d7b43 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -2075,7 +2075,7 @@ struct function_filter_data {
 static char **
 ftrace_function_filter_re(char *buf, int len, int *count)
 {
-	char *str, *sep, **re;
+	char *str, **re;
 
 	str = kstrndup(buf, len, GFP_KERNEL);
 	if (!str)
@@ -2085,8 +2085,7 @@ ftrace_function_filter_re(char *buf, int len, int *count)
 	 * The argv_split function takes white space
 	 * as a separator, so convert ',' into spaces.
 	 */
-	while ((sep = strchr(str, ',')))
-		*sep = ' ';
+	strreplace(str, ',', ' ');
 
 	re = argv_split(GFP_KERNEL, str, count);
 	kfree(str);
-- 
2.1.3


  parent reply	other threads:[~2015-06-08 23:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 23:26 [PATCH v2 0/8] Introduce strreplace Rasmus Villemoes
2015-06-08 23:26 ` [PATCH v2 1/8] lib: string: " Rasmus Villemoes
2015-06-09  0:00   ` Joe Perches
2015-06-09  7:17     ` Rasmus Villemoes
2015-06-08 23:26 ` Rasmus Villemoes [this message]
2015-06-08 23:26 ` [PATCH v2 3/8] blktrace: use strreplace in do_blk_trace_setup Rasmus Villemoes
2015-06-09  3:05   ` Jens Axboe
2015-06-08 23:26 ` [PATCH v2 4/8] lib/kobject.c: Use strreplace Rasmus Villemoes
2015-06-08 23:26 ` [PATCH v2 5/8] drivers/base/core.c: " Rasmus Villemoes
2015-06-08 23:26 ` [PATCH v2 6/8] drivers/md/md.c: " Rasmus Villemoes
2015-06-09 21:17   ` Neil Brown
2015-06-08 23:26 ` [PATCH v2 7/8] fs/jbd2/journal.c: " Rasmus Villemoes
2015-06-08 23:26 ` [PATCH v2 8/8] fs/ext4/super.c: Use strreplace in ext4_fill_super Rasmus Villemoes
2015-06-09  0:55 ` [PATCH v2 0/8] Introduce strreplace Theodore Ts'o
2015-06-09  7:25   ` Rasmus Villemoes
2015-06-09 21:02 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433806017-10823-3-git-send-email-linux@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®