From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932732AbbFIHeO (ORCPT ); Tue, 9 Jun 2015 03:34:14 -0400 Received: from mail-db3on0092.outbound.protection.outlook.com ([157.55.234.92]:26699 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753647AbbFIHeF (ORCPT ); Tue, 9 Jun 2015 03:34:05 -0400 Authentication-Results: spf=fail (sender IP is 212.179.42.66) smtp.mailfrom=ezchip.com; vger.kernel.org; dkim=none (message not signed) header.d=none; From: Gil Fruchter To: , CC: , , , , Gil Fruchter Subject: [PATCH v2 1/2] tracing: Prefer kcalloc over kzalloc with multiply Date: Tue, 9 Jun 2015 10:32:34 +0300 Message-ID: <1433835155-6894-2-git-send-email-gilf@ezchip.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1433251589-21013-1-git-send-email-gilf@ezchip.com> References: <1433251589-21013-1-git-send-email-gilf@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-11.0.0.1191-7.500.1018-21534.006 X-TM-AS-Result: No--4.268900-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD017;1:Q3eisi21RNQxLOW0r1oPR8YPuopENJ+s2Vn1SVurpS7HJR1ri1B5eFlPI4/IVIMOEJm5xZUcX5giYfkAvr8t0Vr69RPVAtwhYMP2wkbSszTMVp2xlfdpytaW3Uuv5CNuTCguZLZbd3zlAWpDW5qIy+lB6xjcjwL2azqR/SayYswnZ5QjwUKz4HuXnNEUzHmMzrfuRfBDEdZfhnBzRQ/S/IoTnyfAUkXmJXcj4+d7flA9z6F3OjKY9wT1N6C9FKVgHcNYNsFnk32YZ9rEHl4DG1tDbqihLJ0wdS4+bVxtxSXsTzxGBGoxZgutqr1XpgK8 X-Forefront-Antispam-Report: CIP:212.179.42.66;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(189002)(199003)(5001770100001)(86362001)(46102003)(2950100001)(77156002)(77096005)(105606002)(104016003)(76176999)(19580405001)(5001920100001)(229853001)(50466002)(87936001)(50986999)(47776003)(85426001)(62966003)(33646002)(106466001)(48376002)(36756003)(5001970100001)(49486002)(189998001)(6806004)(107886002)(50226001)(92566002)(19580395003)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR02MB1138;H:ezex10.ezchip.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB1138; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:AM3PR02MB1138;BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB1138; X-Forefront-PRVS: 06022AA85F X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2015 07:33:59.8750 (UTC) X-MS-Exchange-CrossTenant-Id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3;Ip=[212.179.42.66];Helo=[ezex10.ezchip.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR02MB1138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use kcalloc for allocating an array instead of kzalloc with multiply, as that is what kcalloc is used for. Found with checkpatch. Signed-off-by: Gil Fruchter --- kernel/trace/trace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 0533049..57ffc4a 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3034,7 +3034,7 @@ __tracing_open(struct inode *inode, struct file *file, bool snapshot) if (!iter) return ERR_PTR(-ENOMEM); - iter->buffer_iter = kzalloc(sizeof(*iter->buffer_iter) * num_possible_cpus(), + iter->buffer_iter = kcalloc(num_possible_cpus(), sizeof(*iter->buffer_iter), GFP_KERNEL); if (!iter->buffer_iter) goto release; -- 1.7.1