From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753821AbbFIJtQ (ORCPT ); Tue, 9 Jun 2015 05:49:16 -0400 Received: from victor.provo.novell.com ([137.65.250.26]:34784 "EHLO prv3-mh.provo.novell.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753375AbbFIJtK (ORCPT ); Tue, 9 Jun 2015 05:49:10 -0400 From: Guoqing Jiang To: ccaulfie@redhat.com, teigland@redhat.com Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org, Guoqing Jiang Subject: [PATCH] dlm: remove unnecessary error check Date: Tue, 9 Jun 2015 17:46:12 +0800 Message-Id: <1433843172-8953-1-git-send-email-gqjiang@suse.com> X-Mailer: git-send-email 1.7.12.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang --- fs/dlm/lock.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 35502d4..6fc3de9 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -3656,10 +3656,7 @@ static int send_common(struct dlm_rsb *r, struct dlm_lkb *lkb, int mstype) send_args(r, lkb, ms); - error = send_message(mh, ms); - if (error) - goto fail; - return 0; + return send_message(mh, ms); fail: remove_from_waiters(lkb, msg_reply_type(mstype)); @@ -3763,10 +3760,7 @@ static int send_lookup(struct dlm_rsb *r, struct dlm_lkb *lkb) send_args(r, lkb, ms); - error = send_message(mh, ms); - if (error) - goto fail; - return 0; + return send_message(mh, ms); fail: remove_from_waiters(lkb, DLM_MSG_LOOKUP_REPLY); -- 1.7.12.4