Re: [PATCH v2 2/3] Staging: lustre: fix braces are not necessary in dt_object.c

[Joe Perches <joe@perches.com>]

On Wed, 2015-06-10 at 22:00 +0200, Zoltán Lajos Kis wrote:
> Fixes a braces {} are not necessary for any arm of this statement
> warning in lustre/lustre/obdclass/dt_object.c that was found by
> the checkpatch.pl tool.
> 
> Signed-off-by: Zoltán Lajos Kis <zoltan.lajos.kis@gmail.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/dt_object.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/dt_object.c b/drivers/staging/lustre/lustre/obdclass/dt_object.c
> index 4b5c828d..46fbf21 100644
> --- a/drivers/staging/lustre/lustre/obdclass/dt_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/dt_object.c
> @@ -329,9 +329,9 @@ static struct dt_object *dt_reg_open(const struct lu_env *env,
>  	int result;
>  
>  	result = dt_lookup_dir(env, p, name, fid);
> -	if (result == 0){
> +	if (result == 0)
>  		o = dt_locate(env, dt, fid);
> -	} else
> +	else
>  		o = ERR_PTR(result);
>  
>  	return o;

My preference for this sort of thing is generally:

static struct dt_object *dt_reg_open(const struct lu_env *env,
				     struct dt_device *dt,
				     struct dt_object *p,
				     const char *name,
				     struct lu_fid *fid)
{
	int result;

	result = dt_lookup_dir(env, p, name, fid);
	if (result)
		return ERR_PTR(result);

	return dt_locate(env, dt, fid);
}