mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arun Chandran <achandran@mvista.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, "Michal Simek" <monstr@monstr.eu>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	linux-arm-kernel@lists.infradead.org,
	"Arun Chandran" <achandran@mvista.com>
Subject: [PATCH v2] ARM: zynq: Fix earlyprintk in big endian mode
Date: Fri, 12 Jun 2015 12:23:24 +0530	[thread overview]
Message-ID: <1434092004-21385-1-git-send-email-achandran@mvista.com> (raw)
In-Reply-To: <1433945584-16379-1-git-send-email-achandran@mvista.com>

earlyprintk messages are not appearing on the terminal
emulator during a big endian kernel boot. In BE mode
sending full words to UART will result in unprintable
characters as they are byte swapped versions of printable
ones. So send only bytes.

Signed-off-by: Arun Chandran <achandran@mvista.com>
---
---
Changes since v1:
	removed the byte swapping logic. Just send characters instead.
---
 arch/arm/include/debug/zynq.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S
index bd13ded..de86b92 100644
--- a/arch/arm/include/debug/zynq.S
+++ b/arch/arm/include/debug/zynq.S
@@ -38,7 +38,7 @@
 		.endm
 
 		.macro	senduart,rd,rx
-		str	\rd, [\rx, #UART_FIFO_OFFSET]	@ TXDATA
+		strb	\rd, [\rx, #UART_FIFO_OFFSET]	@ TXDATA
 		.endm
 
 		.macro	waituart,rd,rx
-- 
1.9.1


  parent reply	other threads:[~2015-06-12  6:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 14:13 [PATCH v1] " Arun Chandran
2015-06-11 18:13 ` Michal Simek
2015-06-12  6:58   ` Arun Chandran
2015-06-12  6:53 ` Arun Chandran [this message]
2015-06-12  9:25   ` [PATCH v2] " Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434092004-21385-1-git-send-email-achandran@mvista.com \
    --to=achandran@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®