From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753087AbbFLUVb (ORCPT ); Fri, 12 Jun 2015 16:21:31 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36807 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbbFLUV3 (ORCPT ); Fri, 12 Jun 2015 16:21:29 -0400 From: julien.dehee@gmail.com To: gregkh@linuxfoundation.org, abbotti@mev.co.uk, hsweeten@visionengravers.com, tapaswenipathak@gmail.com, hamohammed.sa@gmail.com, viro@zeniv.linux.org.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Julien Dehee Subject: [PATCH] staging: comedi: replace ENOSYS by proper error codes Date: Fri, 12 Jun 2015 22:20:38 +0200 Message-Id: <1434140438-57879-1-git-send-email-julien.dehee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julien Dehee comedi/comedi_fops.c use ENODEV following open manual comedi/drivers.c use ENOTTY following ioctl manual drivers/serial2002.c use ENOTTY following ioctl manual Signed-off-by: Julien Dehee --- drivers/staging/comedi/comedi_fops.c | 2 +- drivers/staging/comedi/drivers.c | 2 +- drivers/staging/comedi/drivers/serial2002.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 146ab00..6896a1f 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -2611,7 +2611,7 @@ static int comedi_open(struct inode *inode, struct file *file) } if (dev->attached && dev->use_count == 0) { if (!try_module_get(dev->driver->module)) { - rc = -ENOSYS; + rc = -ENODEV; goto out; } if (dev->open) { diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c index ed0b60c..db89096 100644 --- a/drivers/staging/comedi/drivers.c +++ b/drivers/staging/comedi/drivers.c @@ -820,7 +820,7 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it) "driver '%s' does not support attach using comedi_config\n", driv->driver_name); module_put(driv->module); - ret = -ENOSYS; + ret = -ENOTTY; goto out; } dev->driver = driv; diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c index 83da162..929bf20 100644 --- a/drivers/staging/comedi/drivers/serial2002.c +++ b/drivers/staging/comedi/drivers/serial2002.c @@ -101,7 +101,7 @@ static long serial2002_tty_ioctl(struct file *f, unsigned op, if (f->f_op->unlocked_ioctl) return f->f_op->unlocked_ioctl(f, op, param); - return -ENOSYS; + return -ENOTTY; } static int serial2002_tty_write(struct file *f, unsigned char *buf, int count) -- 1.9.1