From: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
linux-pcmcia@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
Subject: [PATCH 1/1] pcmcia: Add missing free_irq()
Date: Sun, 14 Jun 2015 21:14:41 +0900 [thread overview]
Message-ID: <1434284081-7207-1-git-send-email-yos@sslab.ics.keio.ac.jp> (raw)
In yenta_probe(), an irq leak potentially happens when
pcmcia_register_socket() fails. I added the missed call.
Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
---
drivers/pcmcia/yenta_socket.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index 965bd84..7922e30f 100644
--- a/drivers/pcmcia/yenta_socket.c
+++ b/drivers/pcmcia/yenta_socket.c
@@ -1269,6 +1269,8 @@ static int yenta_probe(struct pci_dev *dev, const struct pci_device_id *id)
pcmcia_unregister_socket(&socket->socket);
}
+ if (socket->cb_irq)
+ free_irq(socket->irq, socket);
unmap:
iounmap(socket->base);
release:
--
1.9.1
next reply other threads:[~2015-06-14 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 12:14 Takeshi Yoshimura [this message]
2015-06-14 14:28 ` Dominik Brodowski
2015-06-14 17:21 ` Takeshi Yoshimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434284081-7207-1-git-send-email-yos@sslab.ics.keio.ac.jp \
--to=yos@sslab.ics.keio.ac.jp \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®