From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752871AbbFNUUN (ORCPT ); Sun, 14 Jun 2015 16:20:13 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:43246 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbbFNUTx (ORCPT ); Sun, 14 Jun 2015 16:19:53 -0400 From: Guenter Roeck To: Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH v2 2/2] ARM: debug: Fix unsupported operand in Kconfig.debug Date: Sun, 14 Jun 2015 13:19:46 -0700 Message-Id: <1434313186-22150-2-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1434313186-22150-1-git-send-email-linux@roeck-us.net> References: <1434313186-22150-1-git-send-email-linux@roeck-us.net> X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org arm builds show the following warning. arch/arm/Kconfig.debug:1576:warning: ignoring unsupported character '>' This is due to config DEBUG_UART_8250_WORD bool "Use 32-bit accesses for 8250 UART" depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250 depends on DEBUG_UART_8250_SHIFT >= 2 The unsupported operand causes DEBUG_UART_8250_WORD to be disabled if DEBUG_UART_8250_SHIFT is larger than 2, which is not what is intended. Fixes: 0b4cccbec606 ("ARM: debug: add support for word accesses to debug/8250.S") Cc: Russell King Signed-off-by: Guenter Roeck --- v2: Instead of configuring DEBUG_UART_8250_WORD only if DEBUG_UART_8250_SHIFT == 2, set it if DEBUG_UART_8250_SHIFT is neither 0 nor 1. arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 6608121c6ea5..23a8b4901cb9 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1574,7 +1574,7 @@ config DEBUG_UART_8250_SHIFT config DEBUG_UART_8250_WORD bool "Use 32-bit accesses for 8250 UART" depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250 - depends on DEBUG_UART_8250_SHIFT >= 2 + depends on DEBUG_UART_8250_SHIFT != 0 && DEBUG_UART_8250_SHIFT != 1 default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART0 || \ DEBUG_SOCFPGA_UART1 || ARCH_KEYSTONE || \ DEBUG_ALPINE_UART0 || \ -- 2.1.0