From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755749AbbFOOgL (ORCPT ); Mon, 15 Jun 2015 10:36:11 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:32933 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178AbbFOOgA (ORCPT ); Mon, 15 Jun 2015 10:36:00 -0400 From: Sudip Mukherjee To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 1/3] parport: fix error handling Date: Mon, 15 Jun 2015 20:05:49 +0530 Message-Id: <1434378951-32467-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After registering the device if exclusive access fails for any reason then we need to unregister the device to remove all references. Signed-off-by: Sudip Mukherjee --- drivers/parport/share.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/parport/share.c b/drivers/parport/share.c index 8067f54..d8079e3 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c @@ -907,7 +907,8 @@ parport_register_dev_model(struct parport *port, const char *name, spin_unlock(&port->physport->pardevice_lock); pr_debug("%s: cannot grant exclusive access for device %s\n", port->name, name); - goto err_put_dev; + device_unregister(&par_dev->dev); + goto err_put_port; } port->flags |= PARPORT_FLAG_EXCL; } -- 1.8.1.2