From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756018AbbFOPAo (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Jun 2015 11:00:44 -0400
Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:59006 "EHLO
	lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755995AbbFOPAe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Jun 2015 11:00:34 -0400
Message-ID: <1434380419.2069.38.camel@x220>
Subject: Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain
 driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Caesar Wang <wxt@rock-chips.com>
Cc: heiko@sntech.de, khilman@linaro.org, tomasz.figa@gmail.com,
        ulf.hansson@linaro.org, dmitry.torokhov@gmail.com,
        dianders@chromium.org, linux-rockchip@lists.infradead.org,
        "jinkun.hong" <jinkun.hong@rock-chips.com>,
        Santosh Shilimkar <santosh.shilimkar@ti.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sascha Hauer <s.hauer@pengutronix.de>, Sandeep Nair <sandeep_n@ti.com>,
        Flora Fu <flora.fu@mediatek.com>, Arnd Bergmann <arnd@arndb.de>,
        Stephen Warren <swarren@nvidia.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Date: Mon, 15 Jun 2015 17:00:19 +0200
In-Reply-To: <1434258820-26779-4-git-send-email-wxt@rock-chips.com>
References: <1434258820-26779-1-git-send-email-wxt@rock-chips.com>
	 <1434258820-26779-4-git-send-email-wxt@rock-chips.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote:

> --- /dev/null
> +++ b/drivers/soc/rockchip/Kconfig

> +config PM_GENERIC_DOMAINS
> +        tristate "Rockchip generic power domain"

Since my remarks on v13 you removed the module specific code from 
pm_domains.c. But now this became a tristate symbol. That makes little
sense. Why didn't you keep bool?

> +        depends on PM
> +        help
> +          Say y here to enable power doamin support.

s/doamin/domain/.

> +          In order to meet high performance and low power requirements, a power
> +          management unit is designed or saving power when RK3288 in low power
> +          mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.

s/ot/of/

> +          If unsure, say N.

Thanks,


Paul Bolle