From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756075AbbFOS60 (ORCPT ); Mon, 15 Jun 2015 14:58:26 -0400 Received: from mga03.intel.com ([134.134.136.65]:26430 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755963AbbFOS6M (ORCPT ); Mon, 15 Jun 2015 14:58:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,620,1427785200"; d="scan'208";a="747125439" From: Tomas Winkler To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, Tomas Winkler Subject: [char-misc-next 05/15 V2] mei: bus: don't enable events implicitly in device enable Date: Mon, 15 Jun 2015 21:56:45 +0300 Message-Id: <1434394615-3754-6-git-send-email-tomas.winkler@intel.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1434394615-3754-1-git-send-email-tomas.winkler@intel.com> References: <1434394615-3754-1-git-send-email-tomas.winkler@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not enable events implicitly in mei_cl_enable_device, it should be done explicitly using mei_cl_register_event_cb so the events are enabled only when needed. The NFC drivers has been already using it that way so no need for further changes just remove the code from mei_cl_enable_device. Signed-off-by: Tomas Winkler --- V2: fix the commit message drivers/misc/mei/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 63bd9ad24380..3756f4687292 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -331,9 +331,6 @@ int mei_cl_enable_device(struct mei_cl_device *cldev) mutex_unlock(&bus->device_lock); - if (cldev->event_cb) - mei_cl_read_start(cldev->cl, 0, NULL); - return 0; } EXPORT_SYMBOL_GPL(mei_cl_enable_device); -- 2.4.3