mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: mst@redhat.com, kvm@vger.kernel.org, pbonzini@redhat.com
Subject: [PATCH 5/5] vhost: translate_desc: optimization for desc.len < region size
Date: Tue, 16 Jun 2015 18:33:39 +0200	[thread overview]
Message-ID: <1434472419-148742-6-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1434472419-148742-1-git-send-email-imammedo@redhat.com>

when translating descriptors they are typically less than
memory region that holds them and translated into 1 iov
enty, so it's not nessesary to check remaining length
twice and calculate used length and next address
in such cases.

so relace a remaining length and 'size' increment branches
with a single remaining length check and execute
next iov steps only when it needed.

It saves tiny 2% of translate_desc() execution time.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
PS:
I'm not sure if iov_size > 0 is always true, if it's not
then better to drop this patch.
---
 drivers/vhost/vhost.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 68c1c88..84c457d 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1111,12 +1111,8 @@ static int translate_desc(struct vhost_virtqueue *vq, u64 addr, u32 len,
 	int ret = 0;
 
 	mem = vq->memory;
-	while ((u64)len > s) {
+	do {
 		u64 size;
-		if (unlikely(ret >= iov_size)) {
-			ret = -ENOBUFS;
-			break;
-		}
 		reg = find_region(mem, addr, len, &vq->cached_reg);
 		if (unlikely(!reg)) {
 			ret = -EFAULT;
@@ -1124,13 +1120,22 @@ static int translate_desc(struct vhost_virtqueue *vq, u64 addr, u32 len,
 		}
 		_iov = iov + ret;
 		size = reg->memory_size - addr + reg->guest_phys_addr;
-		_iov->iov_len = min((u64)len - s, size);
 		_iov->iov_base = (void __user *)(unsigned long)
 			(reg->userspace_addr + addr - reg->guest_phys_addr);
+		++ret;
+		if (likely((u64)len - s < size)) {
+			_iov->iov_len = (u64)len - s;
+			break;
+		}
+
+		if (unlikely(ret >= iov_size)) {
+			ret = -ENOBUFS;
+			break;
+		}
+		_iov->iov_len = size;
 		s += size;
 		addr += size;
-		++ret;
-	}
+	} while (1);
 
 	return ret;
 }
-- 
1.8.3.1


  parent reply	other threads:[~2015-06-16 16:34 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 16:33 [PATCH 0/5] vhost: support upto 509 memory regions Igor Mammedov
2015-06-16 16:33 ` [PATCH 1/5] vhost: use binary search instead of linear in find_region() Igor Mammedov
2015-06-16 21:07   ` Michael S. Tsirkin
2015-06-16 21:13     ` Igor Mammedov
2015-06-16 16:33 ` [PATCH 2/5] vhost: extend memory regions allocation to vmalloc Igor Mammedov
2015-06-16 16:33 ` [PATCH 3/5] vhost: support upto 509 memory regions Igor Mammedov
2015-06-16 21:14   ` Michael S. Tsirkin
2015-06-16 22:00     ` Igor Mammedov
2015-06-17  6:34       ` Michael S. Tsirkin
2015-06-17  7:28         ` Igor Mammedov
2015-06-17  7:39           ` Michael S. Tsirkin
2015-06-17  8:54             ` Igor Mammedov
2015-06-17 10:11               ` Michael S. Tsirkin
2015-06-17 10:37                 ` Igor Mammedov
2015-06-17 10:46                   ` Michael S. Tsirkin
2015-06-17 11:48                     ` Igor Mammedov
2015-06-17 11:51                       ` Michael S. Tsirkin
2015-06-17 12:23                         ` Igor Mammedov
2015-06-17 13:13                           ` Michael S. Tsirkin
2015-06-17 13:20                             ` Paolo Bonzini
2015-06-17 14:32                               ` Michael S. Tsirkin
2015-06-17 15:12                                 ` Igor Mammedov
2015-06-17 15:38                                   ` Michael S. Tsirkin
2015-06-17 16:09                                     ` Igor Mammedov
2015-06-17 16:30                                       ` Michael S. Tsirkin
2015-06-17 16:31                                         ` Paolo Bonzini
2015-06-17 16:34                                           ` Michael S. Tsirkin
2015-06-17 16:38                                             ` Paolo Bonzini
2015-06-17 16:41                                               ` Michael S. Tsirkin
2015-06-17 16:47                                                 ` Paolo Bonzini
2015-06-17 17:32                                                   ` Igor Mammedov
2015-06-17 19:11                                                   ` Michael S. Tsirkin
2015-06-17 17:30                                         ` Igor Mammedov
2015-06-18  9:12                                         ` Igor Mammedov
2015-06-18  9:50                                           ` Michael S. Tsirkin
2015-06-18 10:03                                             ` Paolo Bonzini
2015-06-18 11:39                                             ` Igor Mammedov
2015-06-18 11:41                                               ` Michael S. Tsirkin
2015-06-18 11:50                                                 ` Paolo Bonzini
2015-06-18 13:19                                                   ` Michael S. Tsirkin
2015-06-18 13:46                                                     ` Paolo Bonzini
2015-06-18 14:47                                                       ` Michael S. Tsirkin
2015-06-18 15:54                                                         ` Igor Mammedov
2015-06-18 16:02                                                         ` Paolo Bonzini
2015-06-19  7:56                                                           ` Michael S. Tsirkin
2015-06-19  7:57                                                             ` Paolo Bonzini
2015-06-19  8:05                                                               ` Michael S. Tsirkin
2015-06-19  8:52                                                                 ` Paolo Bonzini
2015-06-19 10:14                                                                   ` Michael S. Tsirkin
2015-06-19 10:44                                                                     ` Paolo Bonzini
2015-06-19 13:34                                                                       ` Michael S. Tsirkin
2015-06-19 15:19                                                                         ` Paolo Bonzini
2015-06-19 16:20                                                                           ` Michael S. Tsirkin
2015-06-19 16:26                                                                             ` Paolo Bonzini
2015-06-19 16:33                                                                               ` Michael S. Tsirkin
2015-06-19 16:44                                                                                 ` Paolo Bonzini
2015-06-22  7:10                                                                                 ` Igor Mammedov
2015-06-22  9:45                                                                                   ` Paolo Bonzini
2015-06-19 16:45                                                                   ` Michael S. Tsirkin
2015-06-19 16:50                                                                     ` Paolo Bonzini
2015-06-18 12:02                                                 ` Igor Mammedov
2015-06-17  8:53         ` Paolo Bonzini
2015-06-16 16:33 ` [PATCH 4/5] vhost: add per VQ memory region caching Igor Mammedov
2015-06-16 16:33 ` Igor Mammedov [this message]
2015-06-16 21:11   ` [PATCH 5/5] vhost: translate_desc: optimization for desc.len < region size Michael S. Tsirkin
2015-06-16 21:16 ` [PATCH 0/5] vhost: support upto 509 memory regions Michael S. Tsirkin
2015-06-16 22:19   ` Igor Mammedov
2015-06-17  6:31     ` Michael S. Tsirkin
2015-06-17  7:33       ` Igor Mammedov
2015-06-17  7:40         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434472419-148742-6-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®