mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v2 2/9] staging: sm7xxfb: remove numvgamodes
Date: Wed, 17 Jun 2015 16:54:41 +0530	[thread overview]
Message-ID: <1434540288-8289-3-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1434540288-8289-1-git-send-email-sudipm.mukherjee@gmail.com>

numvgamodes was only used in one place, so remove the #define
and use its defined value.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/staging/sm7xxfb/sm7xx.h   | 2 --
 drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index c5d6253..4dabda4 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -775,5 +775,3 @@ static struct ModeInit vgamode[] = {
 	  },
 	 },
 };
-
-#define numvgamodes		ARRAY_SIZE(vgamode)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 4d9b69d..5667fbf 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -477,7 +477,7 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
 		"sfb->width=%d sfb->height=%d sfb->fb->var.bits_per_pixel=%d sfb->hz=%d\n",
 		sfb->width, sfb->height, sfb->fb->var.bits_per_pixel, sfb->hz);
 
-	for (j = 0; j < numvgamodes; j++) {
+	for (j = 0; j < ARRAY_SIZE(vgamode); j++) {
 		if (vgamode[j].mmsizex == sfb->width &&
 		    vgamode[j].mmsizey == sfb->height &&
 		    vgamode[j].bpp == sfb->fb->var.bits_per_pixel &&
-- 
1.8.1.2


  parent reply	other threads:[~2015-06-17 11:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 11:24 [PATCH v2 0/9] fix sm7xxfb Sudip Mukherjee
2015-06-17 11:24 ` [PATCH v2 1/9] staging: sm7xxfb: declare struct as const Sudip Mukherjee
2015-06-17 11:24 ` Sudip Mukherjee [this message]
2015-06-17 11:24 ` [PATCH v2 3/9] staging: sm7xxfb: add newline Sudip Mukherjee
2015-06-17 11:24 ` [PATCH v2 4/9] staging: sm7xxfb: no space after cast Sudip Mukherjee
2015-06-17 11:24 ` [PATCH v2 5/9] staging: sm7xxfb: fix alignment Sudip Mukherjee
2015-06-19 14:45   ` Dan Carpenter
2015-06-17 11:24 ` [PATCH v2 6/9] staging: sm7xxfb: reduce indention Sudip Mukherjee
2015-06-17 11:24 ` [PATCH v2 7/9] staging: sm7xxfb: move mode table Sudip Mukherjee
2015-06-19 14:48   ` Dan Carpenter
2015-06-17 11:24 ` [PATCH v2 8/9] staging: sm7xxfb: fix indention Sudip Mukherjee
2015-06-19 14:50   ` Dan Carpenter
2015-06-17 11:24 ` [PATCH v2 9/9] staging: sm7xxfb: fix camelcase Sudip Mukherjee
2015-06-19 14:51   ` Dan Carpenter
2015-06-18  4:43 ` [PATCH v2 0/9] fix sm7xxfb Greg Kroah-Hartman
2015-06-18  4:45   ` Greg Kroah-Hartman
2015-06-18  8:37     ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434540288-8289-3-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®