From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B3C374756 for ; Thu, 30 Apr 2026 15:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777563755; cv=none; b=r5jG5u4h/cHzD83FrJDJgj/6G8IVGE9l0O7obmsXxyGRo7tkOjUH5Ch+7FF1GDV1gWYvTU4yTV/HumdUGooVrf8/nd3oRZN/0VlMlHVjPX7R+0l9mnqatzgGb9Jxs8mMXuWDkGW8qNRh2UH2YzeVYRAs396HqkIMWyhT/+qb6Io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777563755; c=relaxed/simple; bh=414dV0w5349LLjdyb3ko0H75tg0jXraSuOz0SGmGXw8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R3zJHaomLNcWzGdd2wJI5LaVzzrUl6JepoMnCMyBJ464BnYept3+1/lLG5lXbBX8i3OFUgeJ9N9RXGJ8BELTB0kukbNTzls+JTh0VID388DzpATNXLvMuijkV3w0WS4Y+1vi9P3YFw/+dAElBNRKCbIAE7z2GKDr00qK/MS7nHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=biiMSzRj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="biiMSzRj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777563750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jWlOrGB3uzSP7r2d6xQ9PldArz9tx4N60VGyQKuxC4s=; b=biiMSzRjrUmJbYHLeKb8z3AiHYhbYfe32Qg3Ibeuzafg/RI349OtW/e1prMoN2msUPPD6m E+USxduwndt6oPAwg2ro6OFVys3dJyByujc3yLhIoJQNRaS0UV1AblXCAN+ZArDpJuoIj3 bDUKfKBlq6QKk44vegwr4Dp1KD/YBZc= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-dbqCerMIND2Pz0bkJPPJxQ-1; Thu, 30 Apr 2026 11:42:29 -0400 X-MC-Unique: dbqCerMIND2Pz0bkJPPJxQ-1 X-Mimecast-MFC-AGG-ID: dbqCerMIND2Pz0bkJPPJxQ_1777563748 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50da31af14cso21911881cf.1 for ; Thu, 30 Apr 2026 08:42:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777563748; x=1778168548; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jWlOrGB3uzSP7r2d6xQ9PldArz9tx4N60VGyQKuxC4s=; b=s0wO8K9pGrJxGFlTry9jPAFxwbtc+I3uGXON9GZKVVM7+8dwq3RhjI8kgPuNS52uVA oxg33CfsBHgLQ/nqAxy5ZlQgfbvvF9o+GSLURc/7M0Qf6vM59WRIBkWW0APKxoDH2zjQ Wn716NQx2isISGWWfQg4E8H+Td93yQ/LpbGXWYrQB+MOASvVG064vSjx1UqgtzJG+waR otbxcxKMopjUxzIOmVbs8Q1O19nYEq2kRAYmGd+gTIOQNJPOEjXL+ZywbA8QyZ/gzwGG V1OC8DkCHv3pjS0S2esWsg/eAz/MswQw7D0wPqmAqf9UYfC5nsPHyRkwqoNAPOf9pzaq CfPw== X-Forwarded-Encrypted: i=1; AFNElJ8muZ/94pnX0a8ys9/oaf6N52K0ebgezqwn0Yt70bYn/FBEcETv0ZZ6f0M1VPNxi8neambsXLxI9DD+jFw=@vger.kernel.org X-Gm-Message-State: AOJu0YztGjstzHCLtlawV7YgJ3F1lTbrioVboQX63A0iRDzMRg1kh2Uv SW1BAH/m7wFceU0nC+vnaUlX4CwCoFwwximNzUf+XGldGVAPsgkzH3itY+AvU+57zRjziHOaX7a /nqQ7b/SsJWO80nQThe5lI69roRl44b7A3FUwjBf7SyAYoUerO9GDXqbo+RFMSOU58w== X-Gm-Gg: AeBDiescFTfLYvfQN9i39Nht2ITJrgOIxMNodT9w9FWMU5WV+xumKJ72WX3gjdootZS HXil4ZqYT+zBLQuRuIZiwml/xBxiF+2p/gIk/I5hyHjk2jPh+NdWcpBTDerggoIRl1mg/wB0nUT NIudgxJZDwZ+s9/1pNo3MtKN7Bipua9xhsjx1Z9HKc3sOHdzfsR1BWS77wHm9d+WpXL0m4DKVGX ENoz+q2Csqfh8p0fRPeFbRGxdnztXuAKDr3yWdotGxKpc8zCqEaT7Yg0IraSJrux2X2teVVVHXv xAhORrpKSUVqs/BgZBP/32bftagQxAL9oOQIo/zDiULmHSbV4onR0opz32exFK6J79a/RUk+Hz1 EPC8c+aSWWOPA34QYk8bibB5GLKj6KE4vFsk= X-Received: by 2002:a05:622a:8ca:b0:50b:526c:541c with SMTP id d75a77b69052e-5102ae320bbmr47576481cf.50.1777563747836; Thu, 30 Apr 2026 08:42:27 -0700 (PDT) X-Received: by 2002:a05:622a:8ca:b0:50b:526c:541c with SMTP id d75a77b69052e-5102ae320bbmr47575841cf.50.1777563747268; Thu, 30 Apr 2026 08:42:27 -0700 (PDT) Received: from [192.168.2.110] ([70.53.202.134]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5103b605192sm1164301cf.24.2026.04.30.08.42.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 08:42:26 -0700 (PDT) Message-ID: <14348c25-a272-4cd8-a9d9-fe8673fb0487@redhat.com> Date: Thu, 30 Apr 2026 11:42:15 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 20/54] selftests/mm: va_high_addr_switch: use kselftest framework To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260428204240.1924129-1-rppt@kernel.org> <20260428204240.1924129-21-rppt@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20260428204240.1924129-21-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-28 16:42, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Convert va_high_addr_switch test to use kselftest framework for > reporting and tracking successful and failing runs. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Luiz Capitulino > --- > .../selftests/mm/va_high_addr_switch.c | 41 +++++++++---------- > 1 file changed, 20 insertions(+), 21 deletions(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.c b/tools/testing/selftests/mm/va_high_addr_switch.c > index 51401e081b20..5d38735ea60e 100644 > --- a/tools/testing/selftests/mm/va_high_addr_switch.c > +++ b/tools/testing/selftests/mm/va_high_addr_switch.c > @@ -257,40 +257,35 @@ void testcases_init(void) > switch_hint = addr_switch_hint; > } > > -static int run_test(struct testcase *test, int count) > +static void run_test(struct testcase *test, int count) > { > void *p; > - int i, ret = KSFT_PASS; > + int i; > > for (i = 0; i < count; i++) { > struct testcase *t = test + i; > > p = mmap(t->addr, t->size, PROT_READ | PROT_WRITE, t->flags, -1, 0); > - > - printf("%s: %p - ", t->msg, p); > - > if (p == MAP_FAILED) { > - printf("FAILED\n"); > - ret = KSFT_FAIL; > + ksft_perror("MAP_FAILED"); > + ksft_test_result_fail("%s\n", t->msg); > continue; > } > > if (t->low_addr_required && p >= (void *)(switch_hint)) { > - printf("FAILED\n"); > - ret = KSFT_FAIL; > + ksft_print_msg("%p not below switch hint\n", p); > + ksft_test_result_fail("%s\n", t->msg); > } else { > /* > * Do a dereference of the address returned so that we catch > * bugs in page fault handling > */ > memset(p, 0, t->size); > - printf("OK\n"); > + ksft_test_result_pass("%s\n", t->msg); > } > if (!t->keep_mapped) > munmap(p, t->size); > } > - > - return ret; > } > > #ifdef __aarch64__ > @@ -322,19 +317,23 @@ static int supported_arch(void) > > int main(int argc, char **argv) > { > - int ret, hugetlb_ret = KSFT_PASS; > + bool run_hugetlb = false; > + > + ksft_print_header(); > > if (!supported_arch()) > - return KSFT_SKIP; > + ksft_exit_skip("Architecture not supported\n"); > + > + if (argc == 2 && !strcmp(argv[1], "--run-hugetlb")) > + run_hugetlb = true; > > testcases_init(); > > - ret = run_test(testcases, sz_testcases); > - if (argc == 2 && !strcmp(argv[1], "--run-hugetlb")) > - hugetlb_ret = run_test(hugetlb_testcases, sz_hugetlb_testcases); > + ksft_set_plan(sz_testcases + (run_hugetlb ? sz_hugetlb_testcases : 0)); > + > + run_test(testcases, sz_testcases); > + if (run_hugetlb) > + run_test(hugetlb_testcases, sz_hugetlb_testcases); > > - if (ret == KSFT_PASS && hugetlb_ret == KSFT_PASS) > - return KSFT_PASS; > - else > - return KSFT_FAIL; > + ksft_finished(); > }