From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933409AbbFVL13 (ORCPT ); Mon, 22 Jun 2015 07:27:29 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:52617 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754282AbbFVL1V (ORCPT ); Mon, 22 Jun 2015 07:27:21 -0400 X-AuditID: cbfee68f-f793b6d000005f66-c0-5587f117f885 From: Umesh Tiwari To: rostedt@goodmis.org, mingo@redhat.com, linux-kernel@vger.kernel.org Cc: gupta.namit@samsung.com, pankaj.m@samsung.com, Umesh Tiwari Subject: [PATCH] ftrace: correct the counter increment for trace_buffer data Date: Mon, 22 Jun 2015 16:55:06 +0530 Message-id: <1434972306-20043-1-git-send-email-umesh.t@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJLMWRmVeSWpSXmKPExsWyRsSkSlf8Y3uowa9t5hYHD5xmtbi8aw6b xaUDC5gs7r3ZymSxr+MBk8WMn1cYHdg8WvbdYvd4v+8qm0ffllWMHp83yQWwRHHZpKTmZJal FunbJXBl/Ho+h7XgBVtF94depgbG56xdjJwcEgImEg13drJD2GISF+6tZ+ti5OIQEljKKDF5 2W4WmKJ1TbegEosYJb4uO8MK4fxklLjROgWsik1AQ+LQ4TY2EFtEwF1i8rH3TCA2s0C4xIz3 txlBbGEBH4m1Z1vAVrMIqEq0ffnPDGLzCjhLHLk4BaieA2ibgsScSTYg8yUE3rNJbL7eA1Uv IPFt8iEWiBpZiU0HmCGOk5Q4uOIGywRGwQWMDKsYRVMLkguKk9KLjPWKE3OLS/PS9ZLzczcx AkP09L9n/TsY7x6wPsQowMGoxMPb+r49VIg1say4MvcQoynQhonMUqLJ+cBIyCuJNzQ2M7Iw NTE1NjK3NFMS510o9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+Oebat7Hpr2bDE/fTmZ wXJNjFDShKzFiyZN+Pb58gG9w7cj/+1jtyp4El/Ht8/W1a77nXejxqMlk//PnSxpkfrK+tZV dgfOGNePAjzbpf/wlR9+NHflvB9rT74Q6Hvg6jBJhM3j0XWNudt4MkU/+vDfNuSrN5vvL7qf tzBFxGHfQWEpa74c+xQlluKMREMt5qLiRADySbIhTAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e+xgK74x/ZQg1uduhYHD5xmtbi8aw6b xaUDC5gs7r3ZymSxr+MBk8WMn1cYHdg8WvbdYvd4v+8qm0ffllWMHp83yQWwRDUw2mSkJqak Fimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAbVdSKEvMKQUKBSQW Fyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZvx6Poe14AVbRfeHXqYGxuesXYycHBICJhLr mm6xQdhiEhfurQeyuTiEBBYxSnxddoYVwvnJKHGjdQoLSBWbgIbEocNtYB0iAu4Sk4+9ZwKx mQXCJWa8v80IYgsL+EisPdsCtoFFQFWi7ct/ZhCbV8BZ4sjFKUD1HEDbFCTmTLKZwMi9gJFh FaNoakFyQXFSeq6hXnFibnFpXrpecn7uJkZwBDyT2sG4ssHiEKMAB6MSD2/C+/ZQIdbEsuLK 3EOMEhzMSiK8LWeBQrwpiZVVqUX58UWlOanFhxhNgZZPZJYSTc4HRmdeSbyhsYm5qbGppYmF iZmlkjjvyXyfUCGB9MSS1OzU1ILUIpg+Jg5OqQbGxPYJai+nctqX8Kz2lCm0enQl6PbqnHur v/lESi58+v+dbV5x+TujJwq3li99lvTmvzKDaPl9pptxr7JtGzmYNkqtf+kYry8d1cae891j XeOxDRv+p3LZqYZs0jZ/61ecv/rcnH2dWn01j1uLn+c9fRi9e0NAmN6cqAjJP23Bi6XSHlo/ 6WNQYinOSDTUYi4qTgQAZtibqZYCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In ftrace_dump, for disabling buffer, iter.tr->trace_buffer.data is used. But for enabling, iter.trace_buffer->data is used. Even though, both point to same buffer, for readability, same convention should be used. Signed-off-by: Umesh Tiwari --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 62c6506..e6dc9c3 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -6698,7 +6698,7 @@ void ftrace_dump(enum ftrace_dump_mode oops_dump_mode) trace_init_global_iter(&iter); for_each_tracing_cpu(cpu) { - atomic_inc(&per_cpu_ptr(iter.tr->trace_buffer.data, cpu)->disabled); + atomic_inc(&per_cpu_ptr(iter.trace_buffer->data, cpu)->disabled); } old_userobj = trace_flags & TRACE_ITER_SYM_USEROBJ; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/