From: Maninder Singh <maninder1.s@samsung.com>
To: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
tvboxspy@gmail.com, gclement@baobob.org, joe@perches.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: pankaj.m@samsung.com, Maninder Singh <maninder1.s@samsung.com>
Subject: [RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb
Date: Wed, 24 Jun 2015 11:43:16 +0530 [thread overview]
Message-ID: <1435126397-6603-1-git-send-email-maninder1.s@samsung.com> (raw)
dev_kfree_skb checks for NULL pointer itself.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
drivers/staging/vt6655/device_main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index ca578d6..0c4b0de 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -767,8 +767,7 @@ static void device_free_td0_ring(struct vnt_private *pDevice)
dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
pTDInfo->skb->len, DMA_TO_DEVICE);
- if (pTDInfo->skb)
- dev_kfree_skb(pTDInfo->skb);
+ dev_kfree_skb(pTDInfo->skb);
kfree(pDesc->pTDInfo);
}
@@ -786,8 +785,7 @@ static void device_free_td1_ring(struct vnt_private *pDevice)
dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
pTDInfo->skb->len, DMA_TO_DEVICE);
- if (pTDInfo->skb)
- dev_kfree_skb(pTDInfo->skb);
+ dev_kfree_skb(pTDInfo->skb);
kfree(pDesc->pTDInfo);
}
--
1.7.9.5
next reply other threads:[~2015-06-24 6:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 6:13 Maninder Singh [this message]
2015-07-14 22:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435126397-6603-1-git-send-email-maninder1.s@samsung.com \
--to=maninder1.s@samsung.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gclement@baobob.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®