From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751790AbbFXIRe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 04:17:34 -0400
Received: from mail-wi0-f176.google.com ([209.85.212.176]:37389 "EHLO
	mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751415AbbFXIR0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 04:17:26 -0400
Message-ID: <1435133843.2334.34.camel@linaro.org>
Subject: Re: [PATCH 8/8] pinctrl: qcom: ssbi: Family A gpio & mpp drivers
From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, Lee Jones <lee.jones@linaro.org>,
        marc.zyngier@arm.com, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Date: Wed, 24 Jun 2015 11:17:23 +0300
In-Reply-To: <1434610052-602-9-git-send-email-bjorn.andersson@sonymobile.com>
References: <1434610052-602-1-git-send-email-bjorn.andersson@sonymobile.com>
	 <1434610052-602-9-git-send-email-bjorn.andersson@sonymobile.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.13.7-fta1.2~trusty 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Bjorn, 

On Wed, 2015-06-17 at 23:47 -0700, Bjorn Andersson wrote:
> This introduces pinctrl drivers for gpio and mpp blocks found in family A
> PMICs.
> 
> +
> +static struct platform_driver pm8xxx_gpio_driver = {
> +       .driver = {
> +               .name = "pm8xxx_gpio",

Name of the SPMI based GPIO PMIC driver is "qcom-spmi-gpio".

You know, all of the PMIC's are PM8..something. Could we have 
SSBI in the name of this one?

> +               .of_match_table = pm8xxx_gpio_of_match,
> +       },
> +       .probe = pm8xxx_gpio_probe,
> +       .remove = pm8xxx_gpio_remove,
> +};
> +
> +module_platform_driver(pm8xxx_gpio_driver);
> +
> +MODULE_AUTHOR("Bjorn Andersson andersson@sonymobile.com>");
> +MODULE_DESCRIPTION("Qualcomm PM8xxx GPIO driver");

And the same of MPP driver.

Regards,
Ivan