From: Maninder Singh <maninder1.s@samsung.com>
To: snitzer@redhat.com, axboe@fb.com, akpm@linux-foundation.org,
benoit.taine@lip6.fr, bhelgaas@google.com, joe@perches.com,
linux-kernel@vger.kernel.org
Cc: pankaj.m@samsung.com, Maninder Singh <maninder1.s@samsung.com>
Subject: [PATCH 1/1] block: remove check around kfree
Date: Wed, 24 Jun 2015 15:33:38 +0530 [thread overview]
Message-ID: <1435140218-25852-1-git-send-email-maninder1.s@samsung.com> (raw)
kfree Checks for NULL poitner itself,
so no need of explicit NULL check
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Rohit Thapliyal <r.thapliyal@samsung.com>
---
drivers/block/skd_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 1e46eb2..c4b0259 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev)
return 0;
msix_out:
- if (entries)
- kfree(entries);
+ kfree(entries);
skd_release_msix(skdev);
return rc;
}
--
1.7.9.5
reply other threads:[~2015-06-24 10:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435140218-25852-1-git-send-email-maninder1.s@samsung.com \
--to=maninder1.s@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=benoit.taine@lip6.fr \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®