From: Paul Bolle <pebolle@tiscali.nl>
To: Michal Simek <michal.simek@xilinx.com>,
Moritz Fischer <moritz.fischer@ettus.com>,
jassisinghbrar@gmail.com
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
soren.brinkmann@xilinx.com, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, mchehab@osg.samsung.com,
arnd@arndb.de, joe@perches.com, jingoohan1@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.
Date: Thu, 25 Jun 2015 11:35:37 +0200 [thread overview]
Message-ID: <1435224937.16792.19.camel@tiscali.nl> (raw)
In-Reply-To: <558BB217.5080200@xilinx.com>
On Thu, 2015-06-25 at 09:47 +0200, Michal Simek wrote:
> It has to be platform_device somewhere for sure.
> In past we had folder in arch/microblaze/platform folder.
> Currently you can add this code to for example
> arch/microblaze/kernel/platform.c
>
> But as I said I don't think it is really important. There will be a
> lot
> of others drivers in the kernel which can be used as platform drivers
> but you are not able to find out platform_device for it.
Because, like probably happens with this driver, the OF infrastructure
makes sure the .probe and .remove functions will eventually called?
> The important part is that driver can work as is.
Sure.
But I was talking about the MODULE_ALIAS() macro. Trivial as it is,
since I still don't see where a "MODALIAS=platform:xilinx-mailbox"
uevent could come from I still don't see the point of this line. As I
asked in my first message: what breaks if this line is dropped?
> Also it is quite common that users create own BSP for their custom
> boards but they don't push it to mainline.
I can't recall what BSP means. Anyhow, why should we care about boards
not pushed into mainline?
Paul Bolle
next prev parent reply other threads:[~2015-06-25 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 18:00 [PATCHv5 0/2] " Moritz Fischer
2015-06-23 18:00 ` [PATCHv5 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver Moritz Fischer
2015-06-23 18:05 ` Sören Brinkmann
2015-06-23 18:23 ` Moritz Fischer
2015-06-23 18:00 ` [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox Moritz Fischer
2015-06-23 18:51 ` Josh Cartwright
2015-06-24 4:55 ` Michal Simek
2015-06-24 20:36 ` Paul Bolle
2015-06-25 6:55 ` Michal Simek
2015-06-25 7:31 ` Paul Bolle
2015-06-25 7:47 ` Michal Simek
2015-06-25 9:35 ` Paul Bolle [this message]
2015-06-25 11:12 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435224937.16792.19.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jassisinghbrar@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=michal.simek@xilinx.com \
--cc=moritz.fischer@ettus.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome