mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wang Nan <wangnan0@huawei.com>
To: <acme@kernel.org>, <ast@plumgrid.com>,
	<brendan.d.gregg@gmail.com>, <daniel@iogearbox.net>,
	<namhyung@kernel.org>, <masami.hiramatsu.pt@hitachi.com>,
	<paulus@samba.org>, <a.p.zijlstra@chello.nl>, <mingo@redhat.com>,
	<jolsa@kernel.org>, <dsahern@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <lizefan@huawei.com>,
	<hekuang@huawei.com>, <xiakaixu@huawei.com>, <pi3orama@163.com>
Subject: [RFC PATCH 1/3] perf probe: Init symbol as kprobe if any pev is kprobe
Date: Thu, 25 Jun 2015 10:37:23 +0000	[thread overview]
Message-ID: <1435228645-116055-2-git-send-email-wangnan0@huawei.com> (raw)
In-Reply-To: <1435228645-116055-1-git-send-email-wangnan0@huawei.com>

Before this patch, add_perf_probe_events() init symbol maps only for
uprobe if the first pev passed to it is a uprobe event. However, with
the incoming BPF uprobe support, now it will be possible to pass an
array with combined kprobe and uprobe events to add_perf_probe_events().

This patch check all pevs instead of the first one, and init kernel
symbol if any events is not uprobe.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
---
 tools/perf/util/probe-event.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index b386d2f..a2b3026 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2802,8 +2802,21 @@ int cleanup_perf_probe_event(struct perf_probe_event *pev)
 int add_perf_probe_events(struct perf_probe_event *pevs, int npevs, bool cleanup)
 {
 	int i, ret;
+	bool user_only = true;
 
-	ret = init_symbol_maps(pevs->uprobes);
+	/* If any pev is kprobe, init kernel symbols. */
+	for (i = 0; i < npevs; i++) {
+		if (!pevs[i].uprobes) {
+			user_only = false;
+			break;
+		}
+	}
+
+	/*
+	 * Compiler can drop user_only:
+	 *  ret = init_symbol_maps(i >= npevs);
+	 */
+	ret = init_symbol_maps(user_only);
 	if (ret < 0)
 		return ret;
 
-- 
1.8.3.4


  reply	other threads:[~2015-06-25 10:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 10:37 [RFC PATCH 0/3] tracing, perf tools: Attach BPF program on uprobe events Wang Nan
2015-06-25 10:37 ` Wang Nan [this message]
2015-06-26  8:49   ` [RFC PATCH 1/3] perf probe: Init symbol as kprobe if any pev is kprobe Alexei Starovoitov
2015-06-27  7:29   ` Masami Hiramatsu
2015-06-27  7:34     ` Wangnan (F)
2015-06-27  8:30       ` Masami Hiramatsu
2015-06-27 11:15         ` Wangnan (F)
2015-06-25 10:37 ` [RFC PATCH 2/3] tracing, perf: Implement BPF programs attached to uprobes Wang Nan
2015-06-26  8:45   ` Alexei Starovoitov
2015-06-25 10:37 ` [RFC PATCH 3/3] perf tools: Support attach BPF program on uprobe events Wang Nan
2015-06-26  8:47   ` Alexei Starovoitov
2015-06-26 11:09     ` Wangnan (F)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435228645-116055-2-git-send-email-wangnan0@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=ast@plumgrid.com \
    --cc=brendan.d.gregg@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=pi3orama@163.com \
    --cc=xiakaixu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®