From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Markus Elfring <elfring@users.sourceforge.net>,
Julia Lawall <julia.lawall@lip6.fr>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
kernel-janitors@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 2/7] perf header: Delete an unnecessary check before the calling free_event_desc()
Date: Thu, 25 Jun 2015 18:10:13 -0300 [thread overview]
Message-ID: <1435266618-10810-3-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1435266618-10810-1-git-send-email-acme@kernel.org>
From: Markus Elfring <elfring@users.sourceforge.net>
The free_event_desc() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/558C2ABA.3000603@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 21a77e7a171e..03ace57a800c 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1063,8 +1063,7 @@ out:
free(buf);
return events;
error:
- if (events)
- free_event_desc(events);
+ free_event_desc(events);
events = NULL;
goto out;
}
--
2.1.0
next prev parent reply other threads:[~2015-06-25 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 21:10 [GIT PULL 0/7] perf/core improvements Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 1/7] perf tools: Future-proof thread_map allocation size calculation Arnaldo Carvalho de Melo
2015-06-25 21:10 ` Arnaldo Carvalho de Melo [this message]
2015-06-25 21:10 ` [PATCH 3/7] perf tools: Add reference counting for cpu_map object Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 4/7] perf tools: Add reference counting for thread_map object Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 5/7] perf evlist: Propagate cpu maps to evsels in an evlist Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 6/7] perf evlist: Propagate thread maps through the evlist Arnaldo Carvalho de Melo
2015-06-25 21:10 ` [PATCH 7/7] perf tools: Make perf_evsel__(nr_)cpus generic Arnaldo Carvalho de Melo
2015-06-26 8:39 ` [GIT PULL 0/7] perf/core improvements Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435266618-10810-3-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome