mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wang Nan <wangnan0@huawei.com>
To: <acme@kernel.org>, <ast@plumgrid.com>,
	<brendan.d.gregg@gmail.com>, <daniel@iogearbox.net>,
	<namhyung@kernel.org>, <masami.hiramatsu.pt@hitachi.com>,
	<paulus@samba.org>, <a.p.zijlstra@chello.nl>, <mingo@redhat.com>,
	<jolsa@kernel.org>, <dsahern@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <lizefan@huawei.com>,
	<hekuang@huawei.com>, <xiakaixu@huawei.com>, <pi3orama@163.com>
Subject: [RFC PATCH v9 01/50] tracing, perf: Implement BPF programs attached to uprobes
Date: Fri, 26 Jun 2015 14:15:06 +0000	[thread overview]
Message-ID: <1435328155-87115-2-git-send-email-wangnan0@huawei.com> (raw)
In-Reply-To: <1435328155-87115-1-git-send-email-wangnan0@huawei.com>

By copying BPF related operation to uprobe processing path, this patch
allow users attach BPF programs to uprobes like what they are already
doing on kprobes.

After this patch, users are allowed to use PERF_EVENT_IOC_SET_BPF on a
uprobe perf event. Which make it possible to profile user space programs
and kernel events together using BPF.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
---
 include/linux/ftrace_event.h | 5 +++++
 kernel/events/core.c         | 4 ++--
 kernel/trace/trace_uprobe.c  | 5 +++++
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
index f9ecf63..eec6f27 100644
--- a/include/linux/ftrace_event.h
+++ b/include/linux/ftrace_event.h
@@ -254,6 +254,7 @@ enum {
 	TRACE_EVENT_FL_USE_CALL_FILTER_BIT,
 	TRACE_EVENT_FL_TRACEPOINT_BIT,
 	TRACE_EVENT_FL_KPROBE_BIT,
+	TRACE_EVENT_FL_UPROBE_BIT,
 };
 
 /*
@@ -268,6 +269,7 @@ enum {
  *  USE_CALL_FILTER - For ftrace internal events, don't use file filter
  *  TRACEPOINT    - Event is a tracepoint
  *  KPROBE        - Event is a kprobe
+ *  UPROBE        - Event is a uprobe
  */
 enum {
 	TRACE_EVENT_FL_FILTERED		= (1 << TRACE_EVENT_FL_FILTERED_BIT),
@@ -278,8 +280,11 @@ enum {
 	TRACE_EVENT_FL_USE_CALL_FILTER	= (1 << TRACE_EVENT_FL_USE_CALL_FILTER_BIT),
 	TRACE_EVENT_FL_TRACEPOINT	= (1 << TRACE_EVENT_FL_TRACEPOINT_BIT),
 	TRACE_EVENT_FL_KPROBE		= (1 << TRACE_EVENT_FL_KPROBE_BIT),
+	TRACE_EVENT_FL_UPROBE		= (1 << TRACE_EVENT_FL_UPROBE_BIT),
 };
 
+#define TRACE_EVENT_FL_UKPROBE (TRACE_EVENT_FL_KPROBE | TRACE_EVENT_FL_UPROBE)
+
 struct ftrace_event_call {
 	struct list_head	list;
 	struct ftrace_event_class *class;
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 9e0773d..18835de 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6775,8 +6775,8 @@ static int perf_event_set_bpf_prog(struct perf_event *event, u32 prog_fd)
 	if (event->tp_event->prog)
 		return -EEXIST;
 
-	if (!(event->tp_event->flags & TRACE_EVENT_FL_KPROBE))
-		/* bpf programs can only be attached to kprobes */
+	if (!(event->tp_event->flags & TRACE_EVENT_FL_UKPROBE))
+		/* bpf programs can only be attached to u/kprobes */
 		return -EINVAL;
 
 	prog = bpf_prog_get(prog_fd);
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 6dd022c..0b580bd 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -1095,11 +1095,15 @@ static void __uprobe_perf_func(struct trace_uprobe *tu,
 {
 	struct ftrace_event_call *call = &tu->tp.call;
 	struct uprobe_trace_entry_head *entry;
+	struct bpf_prog *prog = call->prog;
 	struct hlist_head *head;
 	void *data;
 	int size, esize;
 	int rctx;
 
+	if (prog && !trace_call_bpf(prog, regs))
+		return;
+
 	esize = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
 
 	size = esize + tu->tp.size + dsize;
@@ -1289,6 +1293,7 @@ static int register_uprobe_event(struct trace_uprobe *tu)
 		return -ENODEV;
 	}
 
+	call->flags = TRACE_EVENT_FL_UPROBE;
 	call->class->reg = trace_uprobe_register;
 	call->data = tu;
 	ret = trace_add_event_call(call);
-- 
1.8.3.4


  reply	other threads:[~2015-06-26 14:29 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 14:15 [RFC PATCH v9 00/50] perf tools: filtering events using eBPF programs Wang Nan
2015-06-26 14:15 ` Wang Nan [this message]
2015-06-27 12:10   ` [PATCH] bpf: Use correct #ifdef controller for trace_call_bpf() Wang Nan
2015-06-27 12:36     ` [PATCH v2] " Wang Nan
2015-06-27 12:11   ` [RFC PATCH v9 01/50 -fix] tracing, perf: Implement BPF programs attached to uprobes Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 02/50] tools build: Add feature check for eBPF API Wang Nan
2015-06-29 19:21   ` Arnaldo Carvalho de Melo
2015-06-29 19:41     ` Arnaldo Carvalho de Melo
2015-06-30  2:29       ` Wangnan (F)
2015-06-30 14:34         ` Arnaldo Carvalho de Melo
2015-07-01  1:23           ` Wangnan (F)
2015-06-26 14:15 ` [RFC PATCH v9 03/50] bpf tools: Introduce 'bpf' library to tools Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 04/50] bpf tools: Allow caller to set printing function Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 05/50] bpf tools: Open eBPF object file and do basic validation Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 06/50] bpf tools: Read eBPF object from buffer Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 07/50] bpf tools: Check endianness and make libbpf fail early Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 08/50] bpf tools: Iterate over ELF sections to collect information Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 09/50] bpf tools: Collect version and license from ELF sections Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 10/50] bpf tools: Collect map definitions from 'maps' section Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 11/50] bpf tools: Collect symbol table from SHT_SYMTAB section Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 12/50] bpf tools: Collect eBPF programs from their own sections Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 13/50] bpf tools: Collect relocation sections from SHT_REL sections Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 14/50] bpf tools: Record map accessing instructions for each program Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 15/50] bpf tools: Add bpf.c/h for common bpf operations Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 16/50] bpf tools: Create eBPF maps defined in an object file Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 17/50] bpf tools: Relocate eBPF programs Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 18/50] bpf tools: Introduce bpf_load_program() to bpf.c Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 19/50] bpf tools: Load eBPF programs in object files into kernel Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 20/50] bpf tools: Introduce accessors for struct bpf_program Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 21/50] bpf tools: Introduce accessors for struct bpf_object Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 22/50] bpf tools: Link all bpf objects onto a list Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 23/50] perf tools: Make perf depend on libbpf Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 24/50] perf tools: Introduce llvm config options Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 25/50] perf tools: Call clang to compile C source to object code Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 26/50] perf tests: Add LLVM test for eBPF on-the-fly compiling Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 27/50] perf tools: Auto detecting kernel build directory Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 28/50] perf tools: Auto detecting kernel include options Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 29/50] perf record: Enable passing bpf object file to --event Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 30/50] perf record: Compile scriptlets if pass '.c' " Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 31/50] perf tools: Parse probe points of eBPF programs during preparation Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 32/50] perf probe: Attach trace_probe_event with perf_probe_event Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 33/50] perf record: Probe at kprobe points Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 34/50] perf record: Load all eBPF object into kernel Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 35/50] perf tools: Add bpf_fd field to evsel and config it Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 36/50] perf tools: Attach eBPF program to perf event Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 37/50] perf tools: Suppress probing messages when probing by BPF loading Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 38/50] perf record: Add clang options for compiling BPF scripts Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 39/50] bpf tools: Load a program with different instance using preprocessor Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 40/50] perf tools: Fix probe-event.h include Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 41/50] perf probe: Reset tev->args and tev->nargs when failure Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 42/50] perf tools: Move linux/filter.h to tools/include Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 43/50] perf tools: Add BPF_PROLOGUE config options for further patches Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 44/50] perf tools: Introduce arch_get_reg_info() for x86 Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 45/50] perf tools: Add prologue for BPF programs for fetching arguments Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 46/50] perf tools: Generate prologue for BPF programs Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 47/50] perf tools: Use same BPF program if arguments are identical Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 48/50] perf record: Support custom vmlinux path Wang Nan
2015-06-26 14:15 ` [RFC PATCH v9 49/50] perf probe: Init symbol as kprobe if any event is kprobe Wang Nan
2015-06-27 12:25   ` [RFC PATCH v9 49/50 -fix] " Wang Nan
2015-06-29 14:33     ` Arnaldo Carvalho de Melo
2015-06-30  1:38       ` Wangnan (F)
2015-06-30 14:37         ` Arnaldo Carvalho de Melo
2015-07-01  1:31           ` Wangnan (F)
2015-06-26 14:15 ` [RFC PATCH v9 50/50] perf tools: Support attach BPF program on uprobe events Wang Nan
2015-06-26 22:44 ` [RFC PATCH v9 00/50] perf tools: filtering events using eBPF programs Alexei Starovoitov
2015-06-27  0:14   ` Wangnan (F)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435328155-87115-2-git-send-email-wangnan0@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=ast@plumgrid.com \
    --cc=brendan.d.gregg@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=pi3orama@163.com \
    --cc=xiakaixu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome