From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbbF2Deb (ORCPT ); Sun, 28 Jun 2015 23:34:31 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:32790 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753078AbbF2DeW (ORCPT ); Sun, 28 Jun 2015 23:34:22 -0400 From: Ruben Carlo Benante To: roland@hack.frob.com Cc: oleg@redhat.com, linux-kernel@vger.kernel.org, Ruben Carlo Benante Subject: [PATCH] kernel/ptrace.c: 2 blank lines, 2 sizeof parentheses Date: Mon, 29 Jun 2015 00:34:04 -0300 Message-Id: <1435548844-11433-1-git-send-email-rcb@beco.cc> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed 4 checkpatch.pl warnings: kernel/ptrace.c:270: WARNING: Missing a blank line after declarations kernel/ptrace.c:413: WARNING: Missing a blank line after declarations kernel/ptrace.c:841: WARNING: sizeof siginfo should be sizeof(siginfo) kernel/ptrace.c:1140: WARNING: sizeof siginfo should be sizeof(siginfo) Signed-off-by: Ruben Carlo Benante --- kernel/ptrace.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/ptrace.c b/kernel/ptrace.c index c8e0e05..0759a65 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -264,6 +264,7 @@ ok: bool ptrace_may_access(struct task_struct *task, unsigned int mode) { int err; + task_lock(task); err = __ptrace_may_access(task, mode); task_unlock(task); @@ -407,6 +408,7 @@ static int ptrace_traceme(void) static int ignoring_children(struct sighand_struct *sigh) { int ret; + spin_lock(&sigh->siglock); ret = (sigh->action[SIGCHLD-1].sa.sa_handler == SIG_IGN) || (sigh->action[SIGCHLD-1].sa.sa_flags & SA_NOCLDWAIT); @@ -835,7 +837,7 @@ int ptrace_request(struct task_struct *child, long request, break; case PTRACE_SETSIGINFO: - if (copy_from_user(&siginfo, datavp, sizeof siginfo)) + if (copy_from_user(&siginfo, datavp, sizeof(siginfo))) ret = -EFAULT; else ret = ptrace_setsiginfo(child, &siginfo); @@ -1134,7 +1136,7 @@ int compat_ptrace_request(struct task_struct *child, compat_long_t request, break; case PTRACE_SETSIGINFO: - memset(&siginfo, 0, sizeof siginfo); + memset(&siginfo, 0, sizeof(siginfo)); if (copy_siginfo_from_user32( &siginfo, (struct compat_siginfo __user *) datap)) ret = -EFAULT; -- 2.1.4