From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750913AbbF3JQ7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 30 Jun 2015 05:16:59 -0400
Received: from mailout2.zih.tu-dresden.de ([141.30.67.73]:60846 "EHLO
	mailout2.zih.tu-dresden.de" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750781AbbF3JQu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 30 Jun 2015 05:16:50 -0400
Message-ID: <1435655804.18320.15.camel@mailbox.tu-dresden.de>
Subject: Re: [PATCH 1/1] perf: Fixed indentation errors in Core.py
From: Philipp Trommler <philipp.trommler@mailbox.tu-dresden.de>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Thomas Ilsche <thomas.ilsche@tu-dresden.de>,
        Joseph Schuchart <joseph.schuchart@tu-dresden.de>,
        linux-kernel@vger.kernel.org
Date: Tue, 30 Jun 2015 11:16:44 +0200
In-Reply-To: <1433494892-11682-1-git-send-email-philipp.trommler@mailbox.tu-dresden.de>
References: <1433494892-11682-1-git-send-email-philipp.trommler@mailbox.tu-dresden.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.4 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-TUD-Virus-Scanned: mailout2.zih.tu-dresden.de
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

This is just a short reminder for the patch I sent a few weeks ago. As
it's just a really small change I'd like to ask if someone could review
it, so either I have the chance to fix errors or it can be applied.

Thanks in advance,
Philipp Trommler.

Am Freitag, den 05.06.2015, 11:01 +0200 schrieb Philipp Trommler:
> Those errors prevented the script from running. Just changed some 
> tabs to
> spaces.
> 
> Signed-off-by: Philipp Trommler <
> philipp.trommler@mailbox.tu-dresden.de>
> ---
>  .../python/Perf-Trace-Util/lib/Perf/Trace/Core.py  | 28 +++++++++++-
> ----------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py b/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py
> index 38dfb72..b4a3857 100644
> --- a/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py
> +++ b/tools/perf/scripts/python/Perf-Trace
> -Util/lib/Perf/Trace/Core.py
> @@ -31,7 +31,7 @@ def flag_str(event_name, field_name, value):
>      string = ""
> 
>      if flag_fields[event_name][field_name]:
> -	print_delim = 0
> +        print_delim = 0
>          keys = flag_fields[event_name][field_name]['values'].keys()
>          keys.sort()
>          for idx in keys:
> @@ -55,10 +55,10 @@ def symbol_str(event_name, field_name, value):
>          keys.sort()
>          for idx in keys:
>              if not value and not idx:
> -		string = 
> symbolic_fields[event_name][field_name]['values'][idx]
> +                string = 
> symbolic_fields[event_name][field_name]['values'][idx]
>                  break
> -	    if (value == idx):
> -		string = 
> symbolic_fields[event_name][field_name]['values'][idx]
> +            if (value == idx):
> +                string = 
> symbolic_fields[event_name][field_name]['values'][idx]
>                  break
> 
>      return string
> @@ -77,16 +77,16 @@ def trace_flag_str(value):
>      keys = trace_flags.keys()
> 
>      for idx in keys:
> -	if not value and not idx:
> -	    string += "NONE"
> -	    break
> -
> -	if idx and (value & idx) == idx:
> -	    if print_delim:
> -		string += " | ";
> -	    string += trace_flags[idx]
> -	    print_delim = 1
> -	    value &= ~idx
> +        if not value and not idx:
> +            string += "NONE"
> +            break
> +
> +    if idx and (value & idx) == idx:
> +        if print_delim:
> +            string += " | ";
> +            string += trace_flags[idx]
> +            print_delim = 1
> +            value &= ~idx
> 
>      return string
> 
> --
> 2.4.2