mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Espen Carlsen <ec@numascale.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Espen Carlsen <ec@numascale.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daniel J Blueman <daniel@numascale.com>,
	Steffen Persvold <sp@numascale.com>
Subject: [PATCH, resend] build: fix broken kernel RPM source symlink
Date: Tue, 30 Jun 2015 13:47:22 +0200	[thread overview]
Message-ID: <1435664842-17908-1-git-send-email-ec@numascale.com> (raw)

Fix the 'rpm-pkg' makefile target to always generate the correct
/usr/src/kernel/<ver> symlink; this fails on non-RPM-native systems
eg Ubuntu.

On a non-RPM-native system, the symlink created by rpmbuild points to
the source tree, so the ln -sf commands to overwrite build and source will
create a new link inside the directory pointed to by the build and source
symlinks. This will break the -devel.rpm, as the build and source symlinks
will point to non existing directories after installing them.

Candidate for stable.

Signed-off-by: Espen Carlsen <ec@numascale.com>
---
 scripts/package/mkspec | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/package/mkspec b/scripts/package/mkspec
index d9ab94b..2d28d48 100755
--- a/scripts/package/mkspec
+++ b/scripts/package/mkspec
@@ -123,8 +123,8 @@ echo "mkdir -p "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE"
 echo "EXCLUDES=\"$RCS_TAR_IGNORE --exclude .tmp_versions --exclude=*vmlinux* --exclude=*.o --exclude=*.ko --exclude=*.cmd --exclude=Documentation --exclude=firmware --exclude .config.old --exclude .missing-syscalls.d\""
 echo "tar "'$EXCLUDES'" -cf- . | (cd "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE;tar xvf -)"
 echo 'cd $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE"
-echo "ln -sf /usr/src/kernels/$KERNELRELEASE build"
-echo "ln -sf /usr/src/kernels/$KERNELRELEASE source"
+echo "ln -sfT /usr/src/kernels/$KERNELRELEASE build"
+echo "ln -sfT /usr/src/kernels/$KERNELRELEASE source"
 fi
 
 echo ""
-- 
1.9.1


             reply	other threads:[~2015-06-30 11:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 11:47 Espen Carlsen [this message]
2015-07-04 10:19 ` Paul Bolle
2015-07-06 19:37   ` Espen Carlsen
2015-07-08 14:26     ` Paul Bolle
2015-07-08 15:42       ` Espen Carlsen
2015-07-08 16:18         ` Paul Bolle
2015-07-08 18:47           ` Espen Carlsen
2015-07-08 18:52             ` Paul Bolle
2015-07-08 16:56     ` Paul Bolle
2015-07-09  9:29       ` Espen Carlsen
2015-08-19 15:14 ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435664842-17908-1-git-send-email-ec@numascale.com \
    --to=ec@numascale.com \
    --cc=daniel@numascale.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sp@numascale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome