mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Rajat Jain" <rajatxjain@gmail.com>,
	"Chen, Gong" <gong.chen@linux.intel.com>,
	"Guenter Roeck" <groeck@juniper.net>,
	=?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>,
	linux-api@vger.kernel.org
Subject: [PATCH] pci_regs: reintroduce PCI_MSIX_FLAGS_BIRMASK
Date: Wed, 1 Jul 2015 12:14:10 +0200	[thread overview]
Message-ID: <1435745608-21217-1-git-send-email-mst@redhat.com> (raw)

This partially reverts commit 09a2c73ddfc7f173237fc7209a65b34dd5bcb5ed.
    PCI: Remove unused PCI_MSIX_FLAGS_BIRMASK definition

That commit dropped a symbol from an exported header claiming "no one
uses it". This isn't how Linux normally approaches userspace API though,
and in fact QEMU build fails if trying to use updated headers from linux
3.12 and up.

Sure, userspace can be fixed to use the new symbol, but the cost
of keeping the old one around is fairly low, too.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/uapi/linux/pci_regs.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index efe3443..66644ac 100644
--- a/include/uapi/linux/pci_regs.h
+++ b/include/uapi/linux/pci_regs.h
@@ -319,6 +319,7 @@
 #define PCI_MSIX_PBA		8	/* Pending Bit Array offset */
 #define  PCI_MSIX_PBA_BIR	0x00000007 /* BAR index */
 #define  PCI_MSIX_PBA_OFFSET	0xfffffff8 /* Offset into specified BAR */
+#define  PCI_MSIX_FLAGS_BIRMASK	PCI_MSIX_PBA_BIR /* deprecated */
 #define PCI_CAP_MSIX_SIZEOF	12	/* size of MSIX registers */
 
 /* MSI-X Table entry format */
-- 
MST

             reply	other threads:[~2015-07-01 10:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 10:14 Michael S. Tsirkin [this message]
2015-07-13 15:11 ` Michael S. Tsirkin
2015-07-13 15:49   ` Bjorn Helgaas
2015-07-13 16:32     ` Michael S. Tsirkin
2015-07-14 23:29   ` Bjorn Helgaas
2015-07-27 14:55     ` Michael S. Tsirkin
2015-07-27 16:13       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435745608-21217-1-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=gong.chen@linux.intel.com \
    --cc=groeck@juniper.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rajatxjain@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®