From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752930AbbGAMTU (ORCPT ); Wed, 1 Jul 2015 08:19:20 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:33263 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbbGAMTO (ORCPT ); Wed, 1 Jul 2015 08:19:14 -0400 From: Thierry Reding To: Konrad Rzeszutek Wilk Cc: linux-kernel@vger.kernel.org Subject: [RESEND PATCH] swiotlb: Make linux/swiotlb.h standalone includible Date: Wed, 1 Jul 2015 14:17:58 +0200 Message-Id: <1435753078-13391-1-git-send-email-thierry.reding@gmail.com> X-Mailer: git-send-email 2.4.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding This header file uses the enum dma_data_direction and struct page types without explicitly including the corresponding header files. This makes it rely on the includer to have included the proper headers before. To fix this, include linux/dma-direction.h and forward-declare struct page. The swiotlb_free() function is also annotated __init, therefore requires linux/init.h to be included as well. Signed-off-by: Thierry Reding --- Hi Konrad, I sent this about a year ago and at the time you said you had queued it up, but it never disappeared from my local stack of patches, so here it is again. Thierry include/linux/swiotlb.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index e7a018eaf3a2..017fced60242 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -1,10 +1,13 @@ #ifndef __LINUX_SWIOTLB_H #define __LINUX_SWIOTLB_H +#include +#include #include struct device; struct dma_attrs; +struct page; struct scatterlist; extern int swiotlb_force; -- 2.4.1