From: Maninder Singh <maninder1.s@samsung.com>
To: sameo@linux.intel.com, lee.jones@linaro.org,
linux-kernel@vger.kernel.org
Cc: k.kozlowski@samsung.com, pankaj.m@samsung.com,
Maninder Singh <maninder1.s@samsung.com>
Subject: [PATCH v2] mfd : t7l66xb: remove unnecessary pdata check
Date: Thu, 02 Jul 2015 08:52:58 +0530 [thread overview]
Message-ID: <1435807378-18692-1-git-send-email-maninder1.s@samsung.com> (raw)
o Making pdata NULL check to (!pdata) as coding standard
and all other checks in file.
o Removing redundant check of pdata, because we already
check for pdata, and also derefernced before this check.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
---
v2: changing subject line.
drivers/mfd/t7l66xb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
index c09fb5d..854b05f 100644
--- a/drivers/mfd/t7l66xb.c
+++ b/drivers/mfd/t7l66xb.c
@@ -318,7 +318,7 @@ static int t7l66xb_probe(struct platform_device *dev)
struct resource *iomem, *rscr;
int ret;
- if (pdata == NULL)
+ if (!pdata)
return -EINVAL;
iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
@@ -371,7 +371,7 @@ static int t7l66xb_probe(struct platform_device *dev)
clk_prepare_enable(t7l66xb->clk48m);
- if (pdata && pdata->enable)
+ if (pdata->enable)
pdata->enable(dev);
/* Mask all interrupts */
--
1.7.9.5
next reply other threads:[~2015-07-02 3:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 3:22 Maninder Singh [this message]
2015-07-07 7:18 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435807378-18692-1-git-send-email-maninder1.s@samsung.com \
--to=maninder1.s@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®