From: Julien Grall <julien.grall@citrix.com>
To: <stephen@networkplumber.org>, <davem@davemloft.net>,
<bridge@lists.linux-foundation.org>, <netdev@vger.kernel.org>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
"Julien Grall" <julien.grall@citrix.com>,
Bernhard Thaler <bernhard.thaler@wvnet.at>,
Pablo Neira Ayuso <pablo@netfilter.org>, <fw@strlen.de>,
<ian.campbell@citrix.com>, <wei.liu2@citrix.com>
Subject: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6
Date: Fri, 3 Jul 2015 19:01:31 +0100 [thread overview]
Message-ID: <1435946491-11148-1-git-send-email-julien.grall@citrix.com> (raw)
The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge:
forward IPv6 fragmented packets" introduced a new function
br_validate_ipv6 which take a reference on the inet6 device. Although,
the reference is not released at the end.
This will result to the impossibility to destroy any netdevice using
ipv6 and bridge.
Spotted while trying to destroy a Xen guest on the upstream Linux:
"unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1"
Signed-off-by: Julien Grall <julien.grall@citrix.com>
Cc: Bernhard Thaler <bernhard.thaler@wvnet.at>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: fw@strlen.de
Cc: ian.campbell@citrix.com
Cc: wei.liu2@citrix.com
---
Note that it's impossible to create new guest after this message.
I'm not sure if it's normal.
---
net/bridge/br_netfilter_ipv6.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/bridge/br_netfilter_ipv6.c b/net/bridge/br_netfilter_ipv6.c
index 6d12d26..7046e19 100644
--- a/net/bridge/br_netfilter_ipv6.c
+++ b/net/bridge/br_netfilter_ipv6.c
@@ -140,11 +140,16 @@ int br_validate_ipv6(struct sk_buff *skb)
/* No IP options in IPv6 header; however it should be
* checked if some next headers need special treatment
*/
+
+ in6_dev_put(idev);
+
return 0;
inhdr_error:
IP6_INC_STATS_BH(dev_net(dev), idev, IPSTATS_MIB_INHDRERRORS);
drop:
+ in6_dev_put(idev);
+
return -1;
}
--
2.1.4
next reply other threads:[~2015-07-03 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 18:01 Julien Grall [this message]
2015-07-03 20:42 ` Florian Westphal
2015-07-06 10:35 ` Julien Grall
2015-07-06 11:16 ` Eric Dumazet
2015-07-06 11:19 ` Florian Westphal
2015-07-06 11:32 ` [Xen-devel] " Julien Grall
2015-07-06 9:58 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435946491-11148-1-git-send-email-julien.grall@citrix.com \
--to=julien.grall@citrix.com \
--cc=bernhard.thaler@wvnet.at \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephen@networkplumber.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®