From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755559AbbGFMbn (ORCPT ); Mon, 6 Jul 2015 08:31:43 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:53789 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754646AbbGFMbi (ORCPT ); Mon, 6 Jul 2015 08:31:38 -0400 From: Roger Quadros To: CC: , , , Roger Quadros , Greg Kroah-Hartman Subject: [PATCH] extcon: Fix kernel hang for find_cable_index_by_name() users Date: Mon, 6 Jul 2015 15:31:29 +0300 Message-ID: <1436185889-773-1-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never incremented and end condition is never reached. Fixes: commit 73b6ecdb93e8 ("extcon: Redefine the unique id of supported external connectors without 'enum extcon' type") Cc: Greg Kroah-Hartman Signed-off-by: Roger Quadros --- drivers/extcon/extcon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 76157ab..1acc830 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -138,6 +138,8 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name) id = i; break; } + + i++; } if (id == EXTCON_NONE) -- 2.1.4