mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@linaro.org>
To: eric.auger@st.com, eric.auger@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	christoffer.dall@linaro.org, marc.zyngier@arm.com,
	avi.kivity@gmail.com, mtosatti@redhat.com, feng.wu@intel.com,
	joro@8bytes.org, b.reynal@virtualopensystems.com
Cc: linux-kernel@vger.kernel.org, patches@linaro.org,
	alex.williamson@redhat.com, pbonzini@redhat.com
Subject: [RFC v2 7/9] VFIO: platform: add irq bypass producer management
Date: Mon,  6 Jul 2015 15:24:41 +0200	[thread overview]
Message-ID: <1436189083-32527-8-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1436189083-32527-1-git-send-email-eric.auger@linaro.org>

This patch populates the IRQ bypass callacks:
- stop/resume producer simply consist in disabling/enabling the host irq
- add/del consumer: basically set the automasked flag to false/true
- update remains void

Signed-off-by: Eric Auger <eric.auger@linaro.org>

---

v1 -> v2:
- device handle caching in vfio_platform_device is introduced in a
  separate patch
- use container_of
---
 drivers/vfio/platform/vfio_platform_irq.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c
index d00ed24..7dc17a6 100644
--- a/drivers/vfio/platform/vfio_platform_irq.c
+++ b/drivers/vfio/platform/vfio_platform_irq.c
@@ -222,22 +222,49 @@ static int vfio_platform_is_active(struct vfio_platform_irq *irq)
 
 static void vfio_platform_irq_bypass_stop(struct irq_bypass_producer *prod)
 {
+	disable_irq(prod->irq);
 }
 
 static void vfio_platform_irq_bypass_resume(struct irq_bypass_producer *prod)
 {
+	enable_irq(prod->irq);
 }
 
 static void vfio_platform_irq_bypass_add_consumer(
 			struct irq_bypass_producer *prod,
 			struct irq_bypass_consumer *cons)
 {
+	int ret;
+	struct vfio_platform_irq *irq =
+		container_of(prod, struct vfio_platform_irq, producer);
+
+	//TODO
+	/*
+	 * if the IRQ is active at irqchip level or VFIO (auto)masked
+	 * this means the host IRQ is already under injection in the
+	 * guest and this not safe to change the forwarding state at
+	 * that stage.
+	 * It is not possible to differentiate user-space masking
+	 * from auto-masking, leading to possible false detection of
+	 * active state.
+	 */
+	prod->active = vfio_platform_is_active(irq);
+
+	ret = vfio_platform_set_automasked(irq, false);
+	WARN_ON(ret);
 }
 
 static void vfio_platform_irq_bypass_del_consumer(
 			struct irq_bypass_producer *prod,
 			struct irq_bypass_consumer *cons)
 {
+	struct vfio_platform_irq *irq =
+		container_of(prod, struct vfio_platform_irq, producer);
+
+	if (prod->active)
+		vfio_platform_mask(irq);
+
+	vfio_platform_set_automasked(irq, true);
 }
 
 static int vfio_set_trigger(struct vfio_platform_device *vdev, int index,
-- 
1.9.1


  parent reply	other threads:[~2015-07-06 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 13:24 [RFC v2 0/9] ARM IRQ forward control based on IRQ bypass manager Eric Auger
2015-07-06 13:24 ` [RFC v2 1/9] VFIO: platform: registration of a dummy IRQ bypass producer Eric Auger
2015-07-06 13:24 ` [RFC v2 2/9] VFIO: platform: test forwarded state when selecting IRQ handler Eric Auger
2015-07-06 13:24 ` [RFC v2 3/9] VFIO: platform: single handler using function pointer Eric Auger
2015-07-06 13:24 ` [RFC v2 4/9] VFIO: platform: add vfio_platform_set_automasked Eric Auger
2015-07-06 13:24 ` [RFC v2 5/9] VFIO: platform: add vfio_platform_is_active Eric Auger
2015-07-06 13:24 ` [RFC v2 6/9] irq: bypass: add active field on producer side Eric Auger
2015-07-06 13:24 ` Eric Auger [this message]
2015-07-06 13:24 ` [RFC v2 8/9] KVM: arm/arm64: vgic: forwarding control Eric Auger
2015-07-06 13:24 ` [RFC v2 9/9] KVM: arm/arm64: implement IRQ bypass consumer functions Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436189083-32527-8-git-send-email-eric.auger@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=avi.kivity@gmail.com \
    --cc=b.reynal@virtualopensystems.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@st.com \
    --cc=feng.wu@intel.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mtosatti@redhat.com \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®