mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Oleg Nesterov <oleg@redhat.com>, Christoph Lameter <cl@linux.com>,
	Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 0/3] kmod: Make nohz-full friendly + cleanups
Date: Mon,  6 Jul 2015 17:33:38 +0200	[thread overview]
Message-ID: <1436196821-13962-1-git-send-email-fweisbec@gmail.com> (raw)

Usermodehelpers kernel threads are nohz-full unfriendly because they
force some explicit CPU-wide affinity that happen to disturb user code
that don't want to see noise on isolated CPUs.

So I spent many time on that, despite the one-liner end result.
The out-of-date comments didn't help much, especially it wasn't clear
why we need khelper at all, probably it was first introduced to bring
necessary asynchronous code but I couldn't justify that with the current
code.

I wrote patches to remove it but finally realized we still need it to
inherit a system wide (or nohz-full housekeeping) CPU affinity on
usermodehelper kernel threads because some usermodehelper callers may
have a reduced affinity (eg: per cpu workqueues). All I needed eventually
was to improve the comments to highlight that purpose. And remove a
nohz-full unfriendly wide affinity forcing.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
	nohz/kmod

HEAD: 9a0ad418b7739fbbe4add684551aa5582a58718b

Thanks,
	Frederic
---

Frederic Weisbecker (3):
      kmod: Bunch of internal functions renames
      kmod: Add up-to-date explanations on the purpose of each asynchronous levels
      kmod: Remove unecessary explicit wide CPU affinity setting


 kernel/kmod.c | 61 +++++++++++++++++++++++++++++++++++++++++------------------
 1 file changed, 43 insertions(+), 18 deletions(-)

             reply	other threads:[~2015-07-06 15:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 15:33 Frederic Weisbecker [this message]
2015-07-06 15:33 ` [PATCH 1/3] kmod: Bunch of internal functions renames Frederic Weisbecker
2015-07-06 15:33 ` [PATCH 2/3] kmod: Add up-to-date explanations on the purpose of each asynchronous levels Frederic Weisbecker
2015-07-07 23:07   ` Andrew Morton
2015-07-08 12:54     ` Frederic Weisbecker
2015-07-06 15:33 ` [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity setting Frederic Weisbecker
2015-07-07 16:30   ` Oleg Nesterov
2015-07-07 17:10     ` Frederic Weisbecker
2015-07-07 17:36       ` Oleg Nesterov
2015-07-07 17:38         ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436196821-13962-1-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome