From: Paul Bolle <pebolle@tiscali.nl>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: tom.gall@linaro.org, linaro-mm-sig@lists.linaro.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, daniel.vetter@ffwll.ch,
robdclark@gmail.com, treding@nvidia.com, sumit.semwal@linaro.org,
tom.cooksey@arm.com
Subject: Re: [PATCH v2 1/2] create SMAF module
Date: Tue, 07 Jul 2015 09:59:23 +0200 [thread overview]
Message-ID: <1436255963.20057.106.camel@tiscali.nl> (raw)
In-Reply-To: <1436182827-6218-2-git-send-email-benjamin.gaignard@linaro.org>
A nit only, I'm afraid: a license mismatch.
On ma, 2015-07-06 at 13:40 +0200, Benjamin Gaignard wrote:
> --- /dev/null
> +++ b/drivers/smaf/smaf-core.c
> + * License terms: GNU General Public License (GPL), version 2
> +MODULE_LICENSE("GPL");
The comment at the top of this file states, succinctly, that the license
is GPL v2. And, according to include/linux/module.h, the
MODULE_LICENSE() macro here states that the license is GPL v2 or later.
So I think that either that comment or the ident used in that macro
needs to change.
Ditto for 2/2.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-07-07 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 11:40 [PATCH v2 0/2] RFC: Secure Memory Allocation Framework Benjamin Gaignard
2015-07-06 11:40 ` [PATCH v2 1/2] create SMAF module Benjamin Gaignard
2015-07-07 7:59 ` Paul Bolle [this message]
2015-07-06 11:40 ` [PATCH v2 2/2] SMAF: add CMA allocator Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436255963.20057.106.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=tom.cooksey@arm.com \
--cc=tom.gall@linaro.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®