From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756620AbbGGJOs (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jul 2015 05:14:48 -0400
Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:60421 "EHLO
	lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756511AbbGGJOp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jul 2015 05:14:45 -0400
Message-ID: <1436260472.20057.121.camel@tiscali.nl>
Subject: Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support
From: Paul Bolle <pebolle@tiscali.nl>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Date: Tue, 07 Jul 2015 11:14:32 +0200
In-Reply-To: <1436185763-4308-2-git-send-email-yamada.masahiro@socionext.com>
References: <1436185763-4308-1-git-send-email-yamada.masahiro@socionext.com>
	 <1436185763-4308-2-git-send-email-yamada.masahiro@socionext.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

(I only comment on 1/7, because it's not useful to repeat one remark
seven times.)

On ma, 2015-07-06 at 21:29 +0900, Masahiro Yamada wrote:
> --- /dev/null
> +++ b/drivers/pinctrl/uniphier/Kconfig

> +config PINCTRL_UNIPHIER_CORE
> +	bool
> +	select PINMUX
> +	select GENERIC_PINCONF

> --- /dev/null
> +++ b/drivers/pinctrl/uniphier/Makefile

> +obj-$(CONFIG_PINCTRL_UNIPHIER_CORE)		+= pinctrl-uniphier-core.o

> --- /dev/null
> +++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-core.c

> +#include <linux/module.h>

> +int uniphier_pinctrl_probe(struct platform_device *pdev,
> +			   struct pinctrl_desc *desc,
> +			   struct uniphier_pinctrl_socdata *socdata)
> +{
> +	[...]

> +	desc->owner = THIS_MODULE;

> +	[...]
> +}

This series adds a number of bool Kconfig symbols. So, as far as I can
see, the code it adds can only be built-in.

This series also uses a number of module specific constructs (ie,
THIS_MODULE, MODULE_DEVICE_TABLE, module_exit, MODULE_AUTHOR,
MODULE_DESCRIPTION, and MODULE_LICENSE). So I wonder whether it was
intended to make these new Kconfig symbols tristate instead?

Thanks,


Paul Bolle