From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
To: Roger Quadros <rogerq@ti.com>
Cc: cw00.choi@samsung.com, linux-omap@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().
Date: Tue, 07 Jul 2015 17:04:24 +0300 [thread overview]
Message-ID: <1436277864.2190.5.camel@linaro.org> (raw)
In-Reply-To: <1436274375-10308-1-git-send-email-rogerq@ti.com>
On Tue, 2015-07-07 at 16:06 +0300, Roger Quadros wrote:
> Users of find_cable_index_by_name() will cause a kernel hang
> as the while loop counter is never incremented and end condition
> is never reached.
>
> extcon_get_cable_state() and extcon_set_cable_state() are broken
> because they use cable index instead of cable id. This causes
> the first cable state (cable.0) to be always invalid in sysfs
> or extcon_get_cable_state() users.
>
> Introduce a new function find_cable_id_by_name() that fixes
> both of the above issues.
>
> Fixes: commit 73b6ecdb93e8 ("extcon: Redefine the unique id of supported external connectors without 'enum extcon' type")
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
Thank you. It is fine now. For both patches.
Tested-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
next prev parent reply other threads:[~2015-07-07 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 14:46 [PATCH 0/2] extcon: fixes for v4.2-rc1 Roger Quadros
2015-07-06 14:46 ` [PATCH 1/2] extcon: fix hang and extcon_get/set_cable_state() Roger Quadros
2015-07-07 12:40 ` Ivan T. Ivanov
2015-07-07 12:58 ` Roger Quadros
2015-07-07 13:06 ` [PATCH v2 " Roger Quadros
2015-07-07 14:04 ` Ivan T. Ivanov [this message]
2015-07-10 15:54 ` Chanwoo Choi
2015-07-27 10:39 ` Roger Quadros
2015-07-27 23:26 ` Chanwoo Choi
2015-07-31 3:43 ` Chanwoo Choi
2015-07-06 14:46 ` [PATCH 2/2] extcon: Fix extcon_cable_get_state() from getting old state after notification Roger Quadros
2015-07-31 6:38 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436277864.2190.5.camel@linaro.org \
--to=ivan.ivanov@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome