From: Roger Quadros <rogerq@ti.com>
To: <wg@grandegger.com>, <mkl@pengutronix.de>, <tony@atomide.com>
Cc: <jay.schroeder@garmin.com>, <linux-can@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Roger Quadros <rogerq@ti.com>
Subject: [PATCH 2/2] ARM: dts: dra7x-evm: Prevent glitch on DCAN1 pinmux
Date: Tue, 7 Jul 2015 17:27:57 +0300 [thread overview]
Message-ID: <1436279277-3386-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1436279277-3386-1-git-send-email-rogerq@ti.com>
Driver core sets "default" pinmux on on probe and CAN driver
sets "sleep" pinmux during register. This causes a small window
where the CAN pins are in "default" state with the DCAN module
being disabled.
Change the "default" state to be like sleep so this glitch is
avoided. Add a new "active" state that is used by the driver
when CAN is actually active.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
arch/arm/boot/dts/dra7-evm.dts | 5 +++--
arch/arm/boot/dts/dra72-evm.dts | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index aa46590..096f68b 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -686,7 +686,8 @@
&dcan1 {
status = "ok";
- pinctrl-names = "default", "sleep";
- pinctrl-0 = <&dcan1_pins_default>;
+ pinctrl-names = "default", "sleep", "active";
+ pinctrl-0 = <&dcan1_pins_sleep>;
pinctrl-1 = <&dcan1_pins_sleep>;
+ pinctrl-2 = <&dcan1_pins_default>;
};
diff --git a/arch/arm/boot/dts/dra72-evm.dts b/arch/arm/boot/dts/dra72-evm.dts
index 4e1b605..8037384 100644
--- a/arch/arm/boot/dts/dra72-evm.dts
+++ b/arch/arm/boot/dts/dra72-evm.dts
@@ -587,9 +587,10 @@
&dcan1 {
status = "ok";
- pinctrl-names = "default", "sleep";
- pinctrl-0 = <&dcan1_pins_default>;
+ pinctrl-names = "default", "sleep", "active";
+ pinctrl-0 = <&dcan1_pins_sleep>;
pinctrl-1 = <&dcan1_pins_sleep>;
+ pinctrl-2 = <&dcan1_pins_default>;
};
&qspi {
--
2.1.4
next prev parent reply other threads:[~2015-07-07 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 14:27 [PATCH 0/2] ARM: dra7: fix DCAN glitch Roger Quadros
2015-07-07 14:27 ` [PATCH 1/2] net: can: c_can: Fix default pinmux glitch at init Roger Quadros
2015-07-07 14:33 ` Marc Kleine-Budde
2015-07-07 14:35 ` Roger Quadros
2015-07-07 14:37 ` Roger Quadros
2015-07-07 14:43 ` Marc Kleine-Budde
2015-07-08 8:09 ` Roger Quadros
2015-07-08 8:17 ` Marc Kleine-Budde
2015-07-07 15:49 ` Grygorii Strashko
2015-07-08 8:13 ` Roger Quadros
2015-07-08 10:31 ` Grygorii Strashko
2015-07-08 10:44 ` Roger Quadros
2015-07-08 11:38 ` [PATCH v2 " Roger Quadros
2015-07-09 10:58 ` Grygorii Strashko
2015-07-09 10:59 ` Marc Kleine-Budde
2015-07-09 11:19 ` Grygorii Strashko
2015-07-07 14:27 ` Roger Quadros [this message]
2015-07-09 18:34 ` [PATCH 2/2] ARM: dts: dra7x-evm: Prevent glitch on DCAN1 pinmux Marc Kleine-Budde
2015-07-12 19:18 ` Marc Kleine-Budde
2015-07-13 6:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436279277-3386-3-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=jay.schroeder@garmin.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®