From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935140AbbGHRAj (ORCPT ); Wed, 8 Jul 2015 13:00:39 -0400 Received: from m50-112.126.com ([123.125.50.112]:42671 "EHLO m50-112.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934190AbbGHRAh (ORCPT ); Wed, 8 Jul 2015 13:00:37 -0400 From: Xunlei Pang To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Steven Rostedt , Juri Lelli , Ingo Molnar , Xunlei Pang Subject: [PATCH v5 2/2] sched/deadline: Check to push the task away after its affinity was changed Date: Thu, 9 Jul 2015 00:58:29 +0800 Message-Id: <1436374709-26703-2-git-send-email-xlpang@126.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1436374709-26703-1-git-send-email-xlpang@126.com> References: <1436374709-26703-1-git-send-email-xlpang@126.com> X-CM-TRANSID: j9KowACHr4vlVp1Vvy+DAg--.16591S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7AF4fJw13Jry8Cr13WFWUCFg_yoW8uFyUpF Z2ka45Wa1DJay0q343Zrs5AFy5Wwn7J34ayF1ftrWkCFZ5XF4jvF90vF45XFZxKrn29a12 qF1vqryIkF1jy3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jlc_3UUUUU= X-Originating-IP: [210.21.223.3] X-CM-SenderInfo: p0ost0bj6rjloofrz/1tbiXA0xv1R0XM3ThgAAs7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xunlei Pang (Sync up the same behaviour as that of RT) We may suffer from extra dl overload rq due to the affinity, so when the affinity of any runnable dl task is changed, we should check to trigger balancing, otherwise it will cause some unnecessary delayed real-time response. Unfortunately, current DL global scheduler does nothing about this. This patch modified set_cpus_allowed_dl(), if the target task is runnable but not running and not throttled, it tries to push it away once it got migratable. The patch also solves a problem about move_queued_task() called in set_cpus_allowed_ptr(): When a larger deadline value dl task got migrated due to its curr cpu isn't in the new affinity mask, after move_queued_task() it will miss the chance of pushing away, because check_preempt_curr() called by move_queued_task() doens't set the "need resched flag" for larger deadline value tasks. Signed-off-by: Xunlei Pang --- kernel/sched/deadline.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 20772ee..9f4691f 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -1706,11 +1706,12 @@ static void set_cpus_allowed_dl(struct task_struct *p, weight = cpumask_weight(new_mask); /* - * Only update if the process changes its state from whether it - * can migrate or not. + * Skip updating the migration stuff if the process doesn't change + * its migrate state, but still need to check if it can be pushed + * away due to its new affinity. */ if ((p->nr_cpus_allowed > 1) == (weight > 1)) - return; + goto queue_push; /* * The process used to be able to migrate OR it can now migrate @@ -1727,6 +1728,13 @@ static void set_cpus_allowed_dl(struct task_struct *p, } update_dl_migration(&rq->dl); + +queue_push: + if (weight > 1 && + !task_running(rq, p) && + !test_tsk_need_resched(rq->curr) && + !cpumask_subset(new_mask, &p->cpus_allowed)) + queue_push_tasks(rq); } /* Assumes rq->lock is held */ -- 1.9.1