From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758454AbbGHUkL (ORCPT ); Wed, 8 Jul 2015 16:40:11 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:40101 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755061AbbGHUkG (ORCPT ); Wed, 8 Jul 2015 16:40:06 -0400 Message-ID: <1436387996.20619.54.camel@tiscali.nl> Subject: Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support From: Paul Bolle To: Masahiro Yamada Cc: linux-gpio@vger.kernel.org, Linus Walleij , Linux Kernel Mailing List , linux-arm-kernel Date: Wed, 08 Jul 2015 22:39:56 +0200 In-Reply-To: References: <1436185763-4308-1-git-send-email-yamada.masahiro@socionext.com> <1436185763-4308-2-git-send-email-yamada.masahiro@socionext.com> <1436260472.20057.121.camel@tiscali.nl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On wo, 2015-07-08 at 14:01 +0900, Masahiro Yamada wrote: > Actually, most of pinctrl drivers are boolean, but most of them > conventionally have MODULE_AUTHOR, THIS_MODULE, etc. > > I do not think it looks so weird. Thought? It's a rather common pattern, but I think it's an anti-pattern nevertheless. See the discussion that Shobhit Kumar, Paul Gortmaker, and I had starting in https://lkml.org/lkml/2015/6/20/63 . Please let me know if you're unconvinced by the arguments brought forward by both Pauls in that discussion. Thanks, Paul Bolle