mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Doug Ledford <dledford@redhat.com>
Cc: mtk.manpages@gmail.com, Marcus Gelderie <redmnic@gmail.com>,
	lkml <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	John Duffy <jb_duffy@btinternet.com>,
	Arto Bendiken <arto@bendiken.net>,
	Linux API <linux-api@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] ipc: Modify message queue accounting to not take kernel data structures into account
Date: Wed, 08 Jul 2015 14:49:16 -0700	[thread overview]
Message-ID: <1436392156.12255.99.camel@stgolabs.net> (raw)
In-Reply-To: <559D7760.1020909@redhat.com>

On Wed, 2015-07-08 at 15:17 -0400, Doug Ledford wrote:
> I responded yesterday in the v2 patch thread I believe.  In any case, I
> think this patch is fine, and can go to stable.  This patch doesn't
> actually change the math related to the rlimit checks (which is the main
> thing I wanted to correct in my original patches), instead it corrects a
> mistake I made.  At the time, I mistakenly thought that the qsize
> included the current message data total + the struct msg_msg size total.
>  It didn't, it was just the current user data total.  I added the rbtree
> nodes in order to keep the total accurate but I shouldn't have added the
> rbtree nodes to this total because none of the other kernel usage was
> previously included.

Exactly, this is what I was referring to when I suggested staying clear
from rlimit modifications. It just makes 0 sense to account for each
rbtree.

Thanks for taking a look!

> 
> Acked-by: Doug Ledford <dledford@redhat.com>

Acked-by: Davidlohr Bueso <dbueso@suse.de>


  parent reply	other threads:[~2015-07-08 21:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 22:25 [PATCH v2] ipc: Modify message queue accounting to reflect both total user data and auxiliary kernel data Marcus Gelderie
2015-06-25  5:47 ` Davidlohr Bueso
2015-06-25  7:23   ` Michael Kerrisk (man-pages)
2015-06-25 18:21     ` Davidlohr Bueso
2015-07-06 15:49       ` [PATCH v3] ipc: Modify message queue accounting to not take kernel data structures into account Marcus Gelderie
2015-07-07  5:16         ` Davidlohr Bueso
2015-07-07 13:01           ` Michael Kerrisk (man-pages)
2015-07-08 19:17             ` Doug Ledford
2015-07-08 19:53               ` Michael Kerrisk (man-pages)
2015-07-08 21:49               ` Davidlohr Bueso [this message]
2015-07-10  0:00               ` Davidlohr Bueso
2015-07-11  0:48         ` [PATCH 2/1] ipc,mqueue: Delete bogus overflow check Davidlohr Bueso
2015-07-11  2:03           ` Al Viro
2015-07-11  2:59             ` Doug Ledford
2015-07-14 16:11               ` Marcus Gelderie
2015-06-25 18:50     ` [PATCH v2] ipc: Modify message queue accounting to reflect both total user data and auxiliary kernel data Marcus Gelderie
2015-07-07 18:49       ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436392156.12255.99.camel@stgolabs.net \
    --to=dave@stgolabs.net \
    --cc=akpm@linux-foundation.org \
    --cc=arto@bendiken.net \
    --cc=dhowells@redhat.com \
    --cc=dledford@redhat.com \
    --cc=jb_duffy@btinternet.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=redmnic@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome