mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: inki.dae@samsung.com
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH RESEND v2 2/6] drm/exynos/mixer: fix interrupt clearing
Date: Thu, 09 Jul 2015 10:07:53 +0200	[thread overview]
Message-ID: <1436429273-24144-1-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <559E2703.9090502@samsung.com>

The driver used incorrect flags to clear interrupt status.
The patch fixes it.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_mixer.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index cae98db..25f0aac 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -718,6 +718,10 @@ static irqreturn_t mixer_irq_handler(int irq, void *arg)
 
 	/* handling VSYNC */
 	if (val & MXR_INT_STATUS_VSYNC) {
+		/* vsync interrupt use different bit for read and clear */
+		val |= MXR_INT_CLEAR_VSYNC;
+		val &= ~MXR_INT_STATUS_VSYNC;
+
 		/* interlace scan need to check shadow register */
 		if (ctx->interlace) {
 			base = mixer_reg_read(res, MXR_GRAPHIC_BASE(0));
@@ -743,11 +747,6 @@ static irqreturn_t mixer_irq_handler(int irq, void *arg)
 
 out:
 	/* clear interrupts */
-	if (~val & MXR_INT_EN_VSYNC) {
-		/* vsync interrupt use different bit for read and clear */
-		val &= ~MXR_INT_EN_VSYNC;
-		val |= MXR_INT_CLEAR_VSYNC;
-	}
 	mixer_reg_write(res, MXR_INT_STATUS, val);
 
 	spin_unlock(&res->reg_slock);
-- 
1.9.1


  reply	other threads:[~2015-07-09  8:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09  6:25 [PATCH RESEND 0/6] drm/exynos: HDMI related fixes Andrzej Hajda
2015-07-09  6:25 ` [PATCH RESEND 1/6] drm/exynos/hdmi: fix edid memory leak Andrzej Hajda
2015-07-09  6:25 ` [PATCH RESEND 2/6] drm/exynos/mixer: fix interrupt clearing Andrzej Hajda
2015-07-09  7:47   ` Joonyoung Shim
2015-07-09  8:07     ` Andrzej Hajda [this message]
2015-07-09  9:05       ` [PATCH RESEND v2 " Joonyoung Shim
2015-07-09  6:25 ` [PATCH RESEND 3/6] drm/exynos/mixer: correct vsync configuration sequence Andrzej Hajda
2015-07-09  6:25 ` [PATCH RESEND 4/6] drm/exynos/mixer: always update INT_EN cache Andrzej Hajda
2015-07-09  6:25 ` [PATCH RESEND 5/6] drm/exynos/mixer: simplify poweron flag Andrzej Hajda
2015-07-09  6:25 ` [PATCH RESEND 6/6] drm/exynos/mixer: replace MXR_INT_EN register cache with flag Andrzej Hajda
2015-07-09  7:53 ` [PATCH RESEND 0/6] drm/exynos: HDMI related fixes Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436429273-24144-1-git-send-email-a.hajda@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®