From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbbGIIdA (ORCPT ); Thu, 9 Jul 2015 04:33:00 -0400 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:49557 "EHLO lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbbGIIcv (ORCPT ); Thu, 9 Jul 2015 04:32:51 -0400 Message-ID: <1436430766.20619.91.camel@tiscali.nl> Subject: Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support From: Paul Bolle To: Masahiro Yamada Cc: linux-gpio@vger.kernel.org, Linus Walleij , Linux Kernel Mailing List , linux-arm-kernel Date: Thu, 09 Jul 2015 10:32:46 +0200 In-Reply-To: References: <1436185763-4308-1-git-send-email-yamada.masahiro@socionext.com> <1436185763-4308-2-git-send-email-yamada.masahiro@socionext.com> <1436260472.20057.121.camel@tiscali.nl> <1436387996.20619.54.camel@tiscali.nl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On do, 2015-07-09 at 14:32 +0900, Masahiro Yamada wrote: > After I read your references and thought a bit more, > I am now considering to change the bool into tristate. > > [...] > > Is this OK with you? Whether this should be bool or tristate is up to you and the maintainer (Linus?). I just prefer if you'd be consistent with that choice (ie, you should not use module specific code in a built-in only driver). Thanks, Paul Bolle