From: Wang Nan <wangnan0@huawei.com>
To: <acme@kernel.org>, <ast@plumgrid.com>
Cc: <linux-kernel@vger.kernel.org>, <lizefan@huawei.com>,
<hekuang@huawei.com>, <xiakaixu@huawei.com>, <pi3orama@163.com>
Subject: [PATCH 11/39] bpf tools: Link all bpf objects onto a list
Date: Thu, 9 Jul 2015 12:35:14 +0000 [thread overview]
Message-ID: <1436445342-1402-12-git-send-email-wangnan0@huawei.com> (raw)
In-Reply-To: <1436445342-1402-1-git-send-email-wangnan0@huawei.com>
To allow enumeration of all bpf_objects, keep them in a list (hidden to
caller). bpf_object__for_each_safe() is introduced to do this iteration.
It is safe even user close the object during iteration.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Ahern <dsahern@gmail.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kaixu Xia <xiakaixu@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1435716878-189507-23-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/bpf/libbpf.c | 32 ++++++++++++++++++++++++++++++++
tools/lib/bpf/libbpf.h | 7 +++++++
2 files changed, 39 insertions(+)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index ea6c1a6..b37aab1 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -17,6 +17,7 @@
#include <asm/unistd.h>
#include <linux/kernel.h>
#include <linux/bpf.h>
+#include <linux/list.h>
#include <libelf.h>
#include <gelf.h>
@@ -104,6 +105,8 @@ struct bpf_program {
bpf_program_clear_priv_t clear_priv;
};
+static LIST_HEAD(bpf_objects_list);
+
struct bpf_object {
char license[64];
u32 kern_version;
@@ -137,6 +140,12 @@ struct bpf_object {
} *reloc;
int nr_reloc;
} efile;
+ /*
+ * All loaded bpf_object is linked in a list, which is
+ * hidden to caller. bpf_objects__<func> handlers deal with
+ * all objects.
+ */
+ struct list_head list;
char path[];
};
#define obj_elf_valid(o) ((o)->efile.elf)
@@ -264,6 +273,9 @@ static struct bpf_object *bpf_object__new(const char *path,
obj->efile.obj_buf_sz = obj_buf_sz;
obj->loaded = false;
+
+ INIT_LIST_HEAD(&obj->list);
+ list_add(&obj->list, &bpf_objects_list);
return obj;
}
@@ -943,9 +955,29 @@ void bpf_object__close(struct bpf_object *obj)
}
zfree(&obj->programs);
+ list_del(&obj->list);
free(obj);
}
+struct bpf_object *
+bpf_object__next(struct bpf_object *prev)
+{
+ struct bpf_object *next;
+
+ if (!prev)
+ next = list_first_entry(&bpf_objects_list,
+ struct bpf_object,
+ list);
+ else
+ next = list_next_entry(prev, list);
+
+ /* Empty list is noticed here so don't need checking on entry. */
+ if (&next->list == &bpf_objects_list)
+ return NULL;
+
+ return next;
+}
+
struct bpf_program *
bpf_program__next(struct bpf_program *prev, struct bpf_object *obj)
{
diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
index 657e497..ea8adc2 100644
--- a/tools/lib/bpf/libbpf.h
+++ b/tools/lib/bpf/libbpf.h
@@ -35,6 +35,13 @@ void bpf_object__close(struct bpf_object *object);
int bpf_object__load(struct bpf_object *obj);
int bpf_object__unload(struct bpf_object *obj);
+struct bpf_object *bpf_object__next(struct bpf_object *prev);
+#define bpf_object__for_each_safe(pos, tmp) \
+ for ((pos) = bpf_object__next(NULL), \
+ (tmp) = bpf_object__next(pos); \
+ (pos) != NULL; \
+ (pos) = (tmp), (tmp) = bpf_object__next(tmp))
+
/* Accessors of bpf_program. */
struct bpf_program;
struct bpf_program *bpf_program__next(struct bpf_program *prog,
--
1.8.3.4
next prev parent reply other threads:[~2015-07-09 12:39 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 12:35 [GIT PULL 00/39] perf tools: filtering events using eBPF programs Wang Nan
2015-07-09 12:35 ` [PATCH 01/39] bpf tools: Collect symbol table from SHT_SYMTAB section Wang Nan
2015-07-09 12:35 ` [PATCH 02/39] bpf tools: Collect eBPF programs from their own sections Wang Nan
2015-07-09 15:58 ` Arnaldo Carvalho de Melo
2015-07-10 3:07 ` Wangnan (F)
2015-07-13 19:51 ` Arnaldo Carvalho de Melo
2015-07-14 3:58 ` Wangnan (F)
2015-07-09 12:35 ` [PATCH 03/39] bpf tools: Collect relocation sections from SHT_REL sections Wang Nan
2015-07-09 12:35 ` [PATCH 04/39] bpf tools: Record map accessing instructions for each program Wang Nan
2015-07-09 12:35 ` [PATCH 05/39] bpf tools: Add bpf.c/h for common bpf operations Wang Nan
2015-07-09 12:35 ` [PATCH 06/39] bpf tools: Create eBPF maps defined in an object file Wang Nan
2015-07-13 19:54 ` Arnaldo Carvalho de Melo
2015-07-14 3:59 ` Wangnan (F)
2015-07-09 12:35 ` [PATCH 07/39] bpf tools: Relocate eBPF programs Wang Nan
2015-07-09 12:35 ` [PATCH 08/39] bpf tools: Introduce bpf_load_program() to bpf.c Wang Nan
2015-07-09 12:35 ` [PATCH 09/39] bpf tools: Load eBPF programs in object files into kernel Wang Nan
2015-07-09 12:35 ` [PATCH 10/39] bpf tools: Introduce accessors for struct bpf_program Wang Nan
2015-07-09 12:35 ` Wang Nan [this message]
2015-07-09 12:35 ` [PATCH 12/39] perf tools: Introduce llvm config options Wang Nan
2015-07-21 11:13 ` [PATCH 12/39 update] " Wang Nan
2015-08-08 8:16 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-09 12:35 ` [PATCH 13/39] perf tools: Call clang to compile C source to object code Wang Nan
2015-07-09 12:35 ` [PATCH 14/39] perf tools: Auto detecting kernel build directory Wang Nan
2015-07-13 21:46 ` Arnaldo Carvalho de Melo
2015-07-14 6:56 ` Wangnan (F)
2015-07-14 7:16 ` Wangnan (F)
2015-07-09 12:35 ` [PATCH 15/39] perf tools: Auto detecting kernel include options Wang Nan
2015-08-08 8:17 ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-09 12:35 ` [PATCH 16/39] perf tests: Add LLVM test for eBPF on-the-fly compiling Wang Nan
2015-07-15 10:54 ` [PATCH updated " Wang Nan
2015-07-22 4:46 ` [PATCH 16/39 RESEND] " Wang Nan
2015-07-09 12:35 ` [PATCH 17/39] perf tools: Make perf depend on libbpf Wang Nan
2015-07-09 12:35 ` [PATCH 18/39] perf record: Enable passing bpf object file to --event Wang Nan
2015-07-09 12:35 ` [PATCH 19/39] perf record: Compile scriptlets if pass '.c' " Wang Nan
2015-07-09 12:35 ` [PATCH 20/39] perf tools: Parse probe points of eBPF programs during preparation Wang Nan
2015-07-09 12:35 ` [PATCH 21/39] perf probe: Attach trace_probe_event with perf_probe_event Wang Nan
2015-07-09 12:35 ` [PATCH 22/39] perf record: Probe at kprobe points Wang Nan
2015-07-09 12:35 ` [PATCH 23/39] perf record: Load all eBPF object into kernel Wang Nan
2015-07-09 12:35 ` [PATCH 24/39] perf tools: Add bpf_fd field to evsel and config it Wang Nan
2015-07-09 12:35 ` [PATCH 25/39] perf tools: Attach eBPF program to perf event Wang Nan
2015-07-09 12:35 ` [PATCH 26/39] perf tools: Suppress probing messages when probing by BPF loading Wang Nan
2015-07-09 12:35 ` [PATCH 27/39] perf record: Add clang options for compiling BPF scripts Wang Nan
2015-07-09 12:35 ` [PATCH 28/39] bpf tools: Load a program with different instances using preprocessor Wang Nan
2015-07-13 5:44 ` Wangnan (F)
2015-07-09 12:35 ` [PATCH 29/39] perf tools: Fix probe-event.h include Wang Nan
2015-07-09 12:35 ` [PATCH 30/39] perf probe: Reset args and nargs for probe_trace_event when failure Wang Nan
2015-07-09 12:35 ` [PATCH 31/39] perf tools: Move linux/filter.h to tools/include Wang Nan
2015-07-09 12:35 ` [PATCH 32/39] perf tools: Add BPF_PROLOGUE config options for further patches Wang Nan
2015-07-09 12:35 ` [PATCH 33/39] perf tools: Introduce arch_get_reg_info() for x86 Wang Nan
2015-07-09 12:35 ` [PATCH 34/39] perf tools: Add prologue for BPF programs for fetching arguments Wang Nan
2015-07-09 12:35 ` [PATCH 35/39] perf tools: Generate prologue for BPF programs Wang Nan
2015-07-09 12:35 ` [PATCH 36/39] perf tools: Use same BPF program if arguments are identical Wang Nan
2015-07-09 12:35 ` [PATCH 37/39] perf record: Support custom vmlinux path Wang Nan
2015-07-09 12:35 ` [PATCH 38/39] perf probe: Init symbol as kprobe if any event is kprobe Wang Nan
2015-07-09 12:35 ` [PATCH 39/39] perf tools: Support attach BPF program on uprobe events Wang Nan
2015-07-14 15:36 ` perf test LLVM was: Re: [GIT PULL 00/39] perf tools: filtering events using eBPF programs Arnaldo Carvalho de Melo
2015-07-15 10:49 ` Wangnan (F)
2015-07-15 11:20 ` Arnaldo Carvalho de Melo
2015-07-17 2:34 ` Wangnan (F)
[not found] ` <CA+JHD93=ZMFP0gB1NqTXGBjTfSyYC-53Uj7r11gQJnKtQRKcDg@mail.gmail.com>
2015-07-21 11:09 ` Wangnan (F)
2015-07-21 11:41 ` Arnaldo Carvalho de Melo
2015-07-22 4:40 ` Wangnan (F)
2015-07-31 15:35 ` perf eBPF patch ordering. was: " Arnaldo Carvalho de Melo
2015-07-31 20:31 ` Arnaldo Carvalho de Melo
2015-08-03 2:37 ` Wangnan (F)
2015-08-03 15:07 ` Arnaldo Carvalho de Melo
2015-08-03 15:19 ` Arnaldo Carvalho de Melo
2015-08-03 15:53 ` pi3orama
2015-08-03 16:11 ` Arnaldo Carvalho de Melo
2015-08-03 19:49 ` Arnaldo Carvalho de Melo
2015-08-04 5:28 ` Wangnan (F)
2015-08-04 10:39 ` Wangnan (F)
2015-08-04 15:55 ` Arnaldo Carvalho de Melo
2015-08-04 16:11 ` Arnaldo Carvalho de Melo
2015-08-04 16:13 ` pi3orama
2015-08-06 1:44 ` Wangnan (F)
2015-08-06 14:46 ` Arnaldo Carvalho de Melo
2015-08-06 15:58 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436445342-1402-12-git-send-email-wangnan0@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=hekuang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pi3orama@163.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®