mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Vaishali Thakkar <vthakkar1994@gmail.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] coresight: replicator: Use module_platform_driver
Date: Thu, 09 Jul 2015 22:19:08 +0200	[thread overview]
Message-ID: <1436473148.20619.116.camel@tiscali.nl> (raw)
In-Reply-To: <20150709195944.GA4470@vaishali-Ideapad-Z570>

On vr, 2015-07-10 at 01:29 +0530, Vaishali Thakkar wrote:
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c

> -static int __init replicator_init(void)
> -{
> -	return platform_driver_register(&replicator_driver);
> -}
> -module_init(replicator_init);
> -
> -static void __exit replicator_exit(void)
> -{
> -	platform_driver_unregister(&replicator_driver);
> -}
> -module_exit(replicator_exit);
> +module_platform_driver(replicator_driver);

coresight-replicator.o is built if CONFIG_CORESIGHT_LINKS_AND_SINKS is
defined. CORESIGHT_LINKS_AND_SINKS is a bool symbol. It depends on
CORESIGHT, which is also a bool symbol. CORESIGHT is a top level symbol,
available on arm and arm64.

I think coresight-replicator.o can only be built-in. So I suggest to use
builtin_platform_driver() instead.

Thanks,


Paul Bolle

  reply	other threads:[~2015-07-09 20:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 19:59 Vaishali Thakkar
2015-07-09 20:19 ` Paul Bolle [this message]
2015-07-10  3:23   ` Vaishali Thakkar
2015-07-10  9:00     ` Paul Bolle
2015-07-10 11:47       ` Vaishali Thakkar
2015-07-10 14:30         ` Mathieu Poirier
2015-07-10 15:51           ` Vaishali Thakkar
2015-07-13 15:31             ` Mathieu Poirier
2015-07-14 11:49               ` Vaishali Thakkar
2015-07-14 15:22                 ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436473148.20619.116.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=vthakkar1994@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®