From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751596AbbGMOHx (ORCPT ); Mon, 13 Jul 2015 10:07:53 -0400 Received: from mga02.intel.com ([134.134.136.20]:4483 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbbGMOHw (ORCPT ); Mon, 13 Jul 2015 10:07:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,462,1432623600"; d="scan'208";a="727950887" From: Andy Shevchenko To: linux-kernel@vger.kernel.org, Sascha Hauer , Peter De Schrijver , Tero Kristo , Stephen Boyd , Russell King , Dinh Nguyen Cc: Andy Shevchenko Subject: [PATCH v5 2/8] clk: mmp: switch to GENMASK() Date: Mon, 13 Jul 2015 17:07:42 +0300 Message-Id: <1436796468-45723-3-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436796468-45723-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1436796468-45723-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Convert the code to use GENMASK() helper instead of custom approach. Signed-off-by: Andy Shevchenko --- drivers/clk/mmp/clk-mix.c | 2 +- drivers/clk/mmp/clk.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c index 7a37432..1ff85d7c 100644 --- a/drivers/clk/mmp/clk-mix.c +++ b/drivers/clk/mmp/clk-mix.c @@ -26,7 +26,7 @@ static unsigned int _get_maxdiv(struct mmp_clk_mix *mix) { - unsigned int div_mask = (1 << mix->reg_info.width_div) - 1; + unsigned int div_mask = GENMASK(mix->reg_info.width_div - 1, 0); unsigned int maxdiv = 0; struct clk_div_table *clkt; diff --git a/drivers/clk/mmp/clk.h b/drivers/clk/mmp/clk.h index adf9b71..f5fdb0e 100644 --- a/drivers/clk/mmp/clk.h +++ b/drivers/clk/mmp/clk.h @@ -39,7 +39,7 @@ extern struct clk *mmp_clk_register_factor(const char *name, /* Clock type "mix" */ #define MMP_CLK_BITS_MASK(width, shift) \ - (((1 << (width)) - 1) << (shift)) + (GENMASK((width) - 1, 0) << (shift)) #define MMP_CLK_BITS_GET_VAL(data, width, shift) \ ((data & MMP_CLK_BITS_MASK(width, shift)) >> (shift)) #define MMP_CLK_BITS_SET_VAL(val, width, shift) \ -- 2.1.4