From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Tero Kristo <t-kristo@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v5 6/8] clk: hisilicon: switch to GENMASK()
Date: Mon, 13 Jul 2015 17:07:46 +0300 [thread overview]
Message-ID: <1436796468-45723-7-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1436796468-45723-1-git-send-email-andriy.shevchenko@linux.intel.com>
Convert the code to use GENMASK() helper instead of div_mask() macro.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/clk/hisilicon/clkdivider-hi6220.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/hisilicon/clkdivider-hi6220.c b/drivers/clk/hisilicon/clkdivider-hi6220.c
index 113eee8..65ab03f 100644
--- a/drivers/clk/hisilicon/clkdivider-hi6220.c
+++ b/drivers/clk/hisilicon/clkdivider-hi6220.c
@@ -18,8 +18,6 @@
#include <linux/err.h>
#include <linux/spinlock.h>
-#define div_mask(width) ((1 << (width)) - 1)
-
/**
* struct hi6220_clk_divider - divider clock for hi6220
*
@@ -51,7 +49,7 @@ static unsigned long hi6220_clkdiv_recalc_rate(struct clk_hw *hw,
struct hi6220_clk_divider *dclk = to_hi6220_clk_divider(hw);
val = readl_relaxed(dclk->reg) >> dclk->shift;
- val &= div_mask(dclk->width);
+ val &= GENMASK(dclk->width - 1, 0);
return divider_recalc_rate(hw, parent_rate, val, dclk->table,
CLK_DIVIDER_ROUND_CLOSEST);
@@ -81,7 +79,7 @@ static int hi6220_clkdiv_set_rate(struct clk_hw *hw, unsigned long rate,
spin_lock_irqsave(dclk->lock, flags);
data = readl_relaxed(dclk->reg);
- data &= ~(div_mask(dclk->width) << dclk->shift);
+ data &= ~(GENMASK(dclk->width - 1, 0) << dclk->shift);
data |= value << dclk->shift;
data |= dclk->mask;
@@ -116,7 +114,7 @@ struct clk *hi6220_register_clkdiv(struct device *dev, const char *name,
return ERR_PTR(-ENOMEM);
/* Init the divider table */
- max_div = div_mask(width) + 1;
+ max_div = BIT(width);
min_div = 1;
table = kcalloc(max_div + 1, sizeof(*table), GFP_KERNEL);
--
2.1.4
next prev parent reply other threads:[~2015-07-13 14:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 14:07 [PATCH v5 0/8] clk: replace div_mask() by GENMASK() Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 1/8] clk: divider: switch to GENMASK() Andy Shevchenko
2015-07-21 23:48 ` Stephen Boyd
2015-07-22 13:03 ` Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 2/8] clk: mmp: " Andy Shevchenko
2015-07-21 23:53 ` Stephen Boyd
2015-07-22 13:04 ` Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 3/8] clk: socfpga: " Andy Shevchenko
2015-07-13 15:48 ` Dinh Nguyen
2015-07-22 0:00 ` Stephen Boyd
2015-07-13 14:07 ` [PATCH v5 4/8] clk: ti: divider: " Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 5/8] clk: tegra: " Andy Shevchenko
2015-07-13 14:07 ` Andy Shevchenko [this message]
2015-07-13 14:07 ` [PATCH v5 7/8] clk: bcm: " Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 8/8] ARM: imx: " Andy Shevchenko
2015-10-09 15:41 ` [PATCH v5 0/8] clk: replace div_mask() by GENMASK() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436796468-45723-7-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dinguyen@opensource.altera.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome