From: Minfei Huang <mhuang@redhat.com>
To: akpm@linux-foundation.org, rob.jones@codethink.co.uk,
amhyung@kernel.org, rusty@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org, Minfei Huang <mnfhuang@gmail.com>
Subject: [PATCH 1/2] Define find_symbol_in_section_t as function type to simplify the code
Date: Tue, 14 Jul 2015 14:59:12 +0800 [thread overview]
Message-ID: <1436857153-18874-2-git-send-email-mhuang@redhat.com> (raw)
In-Reply-To: <1436857153-18874-1-git-send-email-mhuang@redhat.com>
From: Minfei Huang <mnfhuang@gmail.com>
It is not elegance, if we use function directly as the argument, like
following:
bool each_symbol_section(bool (*fn)(const struct symsearch *arr,
struct module *owner,
void *data), void *data);
Here introduce a type defined function find_symbol_in_section_t. Now
we can use these type defined function directly, if we want to pass
the function as the argument.
bool each_symbol_section(find_symbol_in_section_t fn, void *data);
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
include/linux/module.h | 6 +++---
kernel/module.c | 9 ++-------
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index d67b193..1e125b1 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -462,14 +462,14 @@ const struct kernel_symbol *find_symbol(const char *name,
bool gplok,
bool warn);
+typedef bool (*find_symbol_in_section_t)(const struct symsearch *arr,
+ struct module *owner, void *data);
/*
* Walk the exported symbol table
*
* Must be called with module_mutex held or preemption disabled.
*/
-bool each_symbol_section(bool (*fn)(const struct symsearch *arr,
- struct module *owner,
- void *data), void *data);
+bool each_symbol_section(find_symbol_in_section_t fn, void *data);
/* Returns 0 and fills in value, defined and namebuf, or -ERANGE if
symnum out of range. */
diff --git a/kernel/module.c b/kernel/module.c
index 4d2b82e..1400c0b 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -426,9 +426,7 @@ extern const unsigned long __start___kcrctab_unused_gpl[];
static bool each_symbol_in_section(const struct symsearch *arr,
unsigned int arrsize,
struct module *owner,
- bool (*fn)(const struct symsearch *syms,
- struct module *owner,
- void *data),
+ find_symbol_in_section_t fn,
void *data)
{
unsigned int j;
@@ -442,10 +440,7 @@ static bool each_symbol_in_section(const struct symsearch *arr,
}
/* Returns true as soon as fn returns true, otherwise false. */
-bool each_symbol_section(bool (*fn)(const struct symsearch *arr,
- struct module *owner,
- void *data),
- void *data)
+bool each_symbol_section(find_symbol_in_section_t fn, void *data)
{
struct module *mod;
static const struct symsearch arr[] = {
--
2.2.2
next prev parent reply other threads:[~2015-07-14 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 6:59 [PATCH 0/2] Using function type to cleanup the function parament Minfei Huang
2015-07-14 6:59 ` Minfei Huang [this message]
2015-07-14 7:04 ` [PATCH 1/2] Define find_symbol_in_section_t as function type to simplify the code Minfei Huang
2015-07-14 21:52 ` Rusty Russell
2015-07-15 2:11 ` Minfei Huang
2015-07-15 20:31 ` Andrew Morton
2015-07-16 11:29 ` Rusty Russell
2015-07-14 6:59 ` [PATCH 2/2] Define kallsyms_cmp_symbol_t " Minfei Huang
2015-07-14 7:05 ` Minfei Huang
2015-07-14 7:06 ` [PATCH 0/2] Using function type to cleanup the function parament Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436857153-18874-2-git-send-email-mhuang@redhat.com \
--to=mhuang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amhyung@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnfhuang@gmail.com \
--cc=rob.jones@codethink.co.uk \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome